Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full fix for installation issue when My Documents on network drive #32799

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

drawbyperpetual
Copy link
Contributor

@drawbyperpetual drawbyperpetual commented May 10, 2024

Summary of the Pull Request

Full fix for #32341 that works for both per-user and per-machine installs.

PR Checklist

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • A new custom action unconditionally writes DSC assets onto [INSTALL FOLDER]\DSCModules.
  • A new custom action is used to install DSC assets to the correct location in the case of a per-user install. These are copied from the [INSTALL FOLDER]\DSCModules location.
  • A WiX-based install is performed (as before) in case of a per-machine install.

Validation Steps Performed

When My Documents is on a network drive (and also when this is not the case),

  • Checked DSC assets correctly installed when installing PerUser / PerMachine.
  • Checked DSC assets correctly installed when upgrading PerUser.
  • Checked DSC assets correctly deleted when uninstalling PerUser / PerMachine. Note that occasionally, the containing folder (e.g. Microsoft.PowerToys.Configure\v0.0.1) is not correctly deleted when My Documents is on a network drive. I think this is because there is a latency-related issue with detecting that the folder is empty on the network drive shortly after having deleted files on it. Note that this issue never seems to occur when My Documents is on a regular drive; the containing folder always correctly gets deleted.

This comment has been minimized.

@drawbyperpetual
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants