Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FindMyMouse] Add Win+Ctrl double press option #32802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gentoli
Copy link

@Gentoli Gentoli commented May 10, 2024

Summary of the Pull Request

Adds hold Windows key + double press Ctrl as an activation option. Adding a more physical option since Windows game mode does not activate sometimes. Since this is relatively short, no new github issue is created. See considerations in Additional comments.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Functional:

  • New option in JSON Config/UI. UI only shows the option when the activation mode is using Ctrl.
    • Is there is a better json key name, or display text/comment?
  • Not using "Custom shortcut" since I don't think modifiers only can be captured and adding double click to it would be a larger refactor.
  • Could trivially make this any key + ctrl in the backend, given PowerToys uses win key primarily, only win key should be fine.

Implementation:

  • Not sure what's the performance impact of GetAsyncKeyState, although it's only called on consecutive Ctrl presses when includeWinKey is set.
  • IndexBitFieldToVisibilityConverter is added to allow an item to be visible for multiple ComboBox indices/ActivationMethods. Seems a bit complicated, not sure if there is a better way to do it without being super verbose.

Validation Steps Performed

Local testing - build FindMyMouse, PowerToys.Settings and PowerToys.exe and test with option on and off and checking the new code path is not triggered in other modes.

@Gentoli
Copy link
Author

Gentoli commented May 10, 2024

@microsoft-github-policy-service agree

@htcfreek
Copy link
Collaborator

@Gentoli
Thank tfor your contribution. Please create a new issue for this change.

@Gentoli
Copy link
Author

Gentoli commented May 10, 2024

@htcfreek created #32804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants