[* DateTimev2] Single quote before 2 digit year improvement #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for Units (microsoft#2877) (microsoft#2879) - Support informal degrees in PT and ES (microsoft#2877); - Fix issue in generation of Spanish unit resources; - Re-generate all resources across platforms.
…icrosoft#2878) * Enabling SpanishMexican culture in Number/Unit/DateTimveV2 * Update Spanish number specs according to review Co-authored-by: Colm Dillon <cdillon@ip-192-168-0-108.ec2.internal>
* Add Portuguese DateTime support in Python * Update Specs with Python changes * Fix Number import issue * Update specs according to build and review * Remove empty NotSupported fields from specs
microsoft#2863) (microsoft#2892) Co-authored-by: aitelint <Fabrizio.Sorba@telusinternational.com>
…eTimeRanges (microsoft#2894) * Workaround for TimexProperty.ToString() to not crash on DateTimeRanges * Add TODO for fixing the TimexProperty date range representation properly according to review
Fetch microsoft/Recognizers-Text upstream changes
[NLU-2858] Fetch upstream changes from microsoft:master -> purecloudlabs:master
Merge MS Recognizers into master
Bringing Pureclould Labs master up to-date with Microsoft master
This reverts commit 22f56fd.
Update fork with MS recognizers latest
Sync Fork
This reverts commit bbb9e44.
This reverts commit dc6a5d5.
|
@tellarin Hi Borje, I'm having an issue with this fix and was wondering if you would be more familiar with .NET. While the regexs I changed in #3057 are working for .NET and python, the changes in this PR to those same regexs don't seem to work for .NET. Any suggestions or direction would be greatly appreciated - thanks! |
Conor-Keaney
changed the title
|
Hello @tellarin, would you be able to review this pull request whenever suits? Thanks! |
|
Hi @tellarin, would you be able to give this a review whenever possible please, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.