Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status Chart: Fix CSS loading race #2967

Merged
merged 9 commits into from Jul 30, 2022
Merged

Status Chart: Fix CSS loading race #2967

merged 9 commits into from Jul 30, 2022

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jul 29, 2022 •
edited

Fixes #2963.

As usual, this contains a "DROP BEFORE MERGING: Regen built/status_chart.mjs." commit to make the live preview work.

馃搲 Live preview: stephantlavavej.github.io/STL/

@StephanTLavavej StephanTLavavej added bug Something isn't working documentation Related to documentation or comments labels Jul 29, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner July 29, 2022 11:31
@StephanTLavavej StephanTLavavej linked an issue Jul 29, 2022 that may be closed by this pull request
Status Chart: Charts may end up monochromatic if the stylesheet loads slowly #2963
Closed
@StephanTLavavej StephanTLavavej added this to Final Review in Code Reviews Jul 29, 2022
@strega-nil-ms strega-nil-ms self-assigned this Jul 29, 2022
strega-nil-ms
strega-nil-ms approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@strega-nil-ms strega-nil-ms moved this from Final Review to Ready To Merge in Code Reviews Jul 29, 2022
@strega-nil-ms strega-nil-ms removed their assignment Jul 29, 2022
@StephanTLavavej StephanTLavavej merged commit 6150d22 into microsoft:gh-pages Jul 30, 2022
Code Reviews automation moved this from Ready To Merge to Done Jul 30, 2022
This was referenced Jul 30, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Related to documentation or comments
Projects
No open projects
Code Reviews
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status Chart: Charts may end up monochromatic if the stylesheet loads slowly
2 participants
@StephanTLavavej @strega-nil-ms