-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Azure Pipelines #4638
Closed
Closed
Test Azure Pipelines #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
infrastructure
Related to repository automation
uncharted
Excluded from the Status Chart
labels
Apr 28, 2024
StephanTLavavej
force-pushed
the
more-azure
branch
2 times, most recently
from
April 28, 2024 07:11
20d526c
to
9acd056
Compare
StephanTLavavej
force-pushed
the
more-azure
branch
from
April 28, 2024 07:33
9acd056
to
57bca8e
Compare
StephanTLavavej
force-pushed
the
more-azure
branch
2 times, most recently
from
April 29, 2024 08:07
f7411b8
to
bb9f485
Compare
StephanTLavavej
force-pushed
the
more-azure
branch
from
April 29, 2024 09:25
bb9f485
to
0cbb567
Compare
StephanTLavavej
force-pushed
the
more-azure
branch
6 times, most recently
from
May 1, 2024 08:36
84c63b8
to
c41bb95
Compare
StephanTLavavej
force-pushed
the
more-azure
branch
2 times, most recently
from
May 8, 2024 21:47
15ea8f9
to
0c608d1
Compare
StephanTLavavej
force-pushed
the
more-azure
branch
from
May 11, 2024 22:09
0c608d1
to
2f61ccc
Compare
StephanTLavavej
force-pushed
the
more-azure
branch
from
May 11, 2024 22:53
2f61ccc
to
b3fb53d
Compare
Use case-sensitive matching for 'PROVISION_IMAGE_SUCCEEDED'.
We need to preserve the original filename 'PowerShell-7.4.2-win-x64.msi' instead of generating 'RANDOM.exe'.
CUDA is 3 GB, so this may be helpful.
This uses a case-sensitive comparison; the default is case-insensitive.
The progress bar message makes the `Write-Host` messages unnecessary. `-ResourceId $VM.ID` is much shorter than `-ResourceGroupName $ResourceGroupName -Name $Name`, allowing us to directly say `'PowerState/stopped'` without wrapping. The original implementation in GH 633 (named `Start-WaitForShutdown`) was verbose, justifying a separate function, but now a direct loop is clearer.
`$ErrorActionPreference` wasn't useful because sysprep is a native command. `Write-Host` wasn't useful because we aren't printing the message returned by `Invoke-AzVMRunCommand`. The PowerShell call operator `&` wasn't useful because we aren't expanding any variables here.
No changes except for: * Drop redundant banner. * `$DiffFile` was never passed as an argument, so set it as an ordinary variable. * Indentation.
Simplify by using the PowerShell redirection operator `>` instead of `Start-Process`. https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_redirection?view=powershell-7.4#powershell-redirection-operators Verified that the diff can be applied cleanly.
Overhaul messaging.
Actually name the file format.diff before uploading, as this appears in the zip.
Name the zip differently from the file within.
Style: Avoid Yoda condition when checking `git diff` output.
StephanTLavavej
force-pushed
the
more-azure
branch
2 times, most recently
from
May 21, 2024 00:35
f94fddc
to
b6e45e9
Compare
They were talking about our old scale set system. Now they talk about hosted pools, and explain the overall process in more detail.
Not yet required - the internal toolset is still 19.40.
StephanTLavavej
force-pushed
the
more-azure
branch
from
May 22, 2024 01:44
b6e45e9
to
9c345ae
Compare
MSVC no longer emits warning C4521 'multiple copy constructors specified', since at least MSVC-PR-368907 on 2021-12-09.
…n building the static debug STL with ASan enabled".
/azp run STL-ASan-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
…ssue when building the static debug STL with ASan enabled"." This reverts commit 67cb400.
/azp run STL-ASan-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for review.