Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @mdn/browser-compat-data to fetch updated mdn API data #1386

Closed
wants to merge 3 commits into from

Conversation

Ahmed-Hakeem
Copy link

this update will solve this issue #1384

@mathe42
Copy link
Contributor

mathe42 commented Aug 30, 2022

You have to run npm i npm run build and npm run baseline-accept localy and commit results!

@saschanaz
Copy link
Contributor

saschanaz commented Aug 30, 2022

mdn/browser-compat-data#17127 is the major blocker here. We'll have to workaround it somehow, probably in bcd-idl-mapper. (Otherwise a lot of members of GlobalEventHandlers will be removed.)

@saschanaz
Copy link
Contributor

Fixed in #1394, thanks!

@github-actions close

@github-actions
Copy link
Contributor

Closing because @saschanaz is one of the code-owners of this repository.

@github-actions github-actions bot closed this Sep 17, 2022
@Ahmed-Hakeem
Copy link
Author

Fixed in #1394, thanks!

@github-actions close

It's my pleasure 😊❤️, I think this will solve this issue but it won't solve your concern here mdn/browser-compat-data#17127 you will have to care about it in every build until you make a workaround inside bcd-idl-mapper.

I hoped you made these changes inside this pull request, but anyway the most important thing is that the issue has been solved, thanks ❤️.

@saschanaz
Copy link
Contributor

saschanaz commented Sep 18, 2022

I think this will solve this issue but it won't solve your concern here mdn/browser-compat-data#17127 you will have to care about it in every build until you make a workaround inside bcd-idl-mapper.

I worked around it in https://github.com/saschanaz/bcd-idl-mapper/blob/7c0d88d755a5836b9d6e4550f850be2f2e9f8a4b/lib/mixin/search.js#L33. For now it should be sufficient for us.

@Ahmed-Hakeem
Copy link
Author

I think this will solve this issue but it won't solve your concern here mdn/browser-compat-data#17127 you will have to care about it in every build until you make a workaround inside bcd-idl-mapper.

I worked around it in https://github.com/saschanaz/bcd-idl-mapper/blob/7c0d88d755a5836b9d6e4550f850be2f2e9f8a4b/lib/mixin/search.js#L33. For now it should be sufficient for us.

Great, thank you ❤️

@Ahmed-Hakeem Ahmed-Hakeem deleted the patch-1 branch September 18, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants