Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract test snapshot builder into class #713

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dplain90
Copy link

As a VSCode Programming Language Extension creator I want to test my tmLanguage file using the TypeScript-TmLanguage test suite to ensure my extension supports all future and current TS language use-cases.

This is not possible in it's current state as the snapshot build script has hardcoded file names and config settings.

This PR does the following:

  • Refactors tests/build.ts into a Builder class tests/builder.ts which can be passed configuration options

  • Uses a Builder instance in tests/test.ts to generate scopes

@msftclas
Copy link

msftclas commented Jan 24, 2019

CLA assistant check
All CLA requirements met.

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change file names and also do not convert to class, You can always use function instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants