Consume leading docblock *s #740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#467 Adds a begin/while rule so that doc blocks also consume the leading *. This approach has been used by VS Code to support highlighting example blocks (see microsoft#693) Remove the `invalid.illegal.type.jsdoc` rule since we now can highlight multiline types better
| - include: '#docblock' | ||
| - contentName: comment.block.documentation.body.ts | ||
| begin: (?<=/\*\*)([^*]|\*(?!/))*$ | ||
| while: (^|\G)\s*\*(?!/)(?=([^*]|[*](?!/))*$) |
There was a problem hiding this comment.
The while pattern does not work in sublime and results in error and hence cannot be applied in this repo as it sublime typescript package also uses this grammar.
There was a problem hiding this comment.
Unfortunately is no way to implement this without begin/while. I can keep this grammar modification VS Code but it means that other consumers of this grammar (like VS) will not benefit
sheetalkamat
force-pushed
the
master
branch
7 times, most recently
from
38ce771
to
0e1f58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
Adds a begin/while rule so that doc blocks also consume the leading *. This approach has been used by VS Code to support highlighting example blocks (see Highlight @example jsdoc body as source code #693). This allows injected grammars to not know they are being used inside a doc block
Remove the
invalid.illegal.type.jsdocrule since we now can highlight multiline types betterBefore, without the begin/while rule:
After: