Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds highlighting for the 'accessor' keyword #917

Merged
merged 2 commits into from Nov 11, 2022
Merged

Adds highlighting for the 'accessor' keyword #917

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95d00da
Adds highlighting for the 'accessor' keyword
rbuckton Jun 29, 2022
c3ce78f
Merge branch 'master' into auto-accessor
sheetalkamat Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion TypeScript.YAML-tmLanguage
View file
Open in desktop
Expand Up @@ -1004,7 +1004,7 @@ repository:

property-accessor:
name: storage.type.property.ts
match: '{{startOfIdentifier}}(get|set){{endOfIdentifier}}'
match: '{{startOfIdentifier}}(accessor|get|set){{endOfIdentifier}}'

async-modifier:
name: storage.modifier.async.ts
Expand Down
2 changes: 1 addition & 1 deletion TypeScript.tmLanguage
View file
Open in desktop
Expand Up @@ -3173,7 +3173,7 @@
<key>name</key>
<string>storage.type.property.ts</string>
<key>match</key>
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))(get|set)(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))(accessor|get|set)(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
</dict>
<key>async-modifier</key>
<dict>
Expand Down
2 changes: 1 addition & 1 deletion TypeScriptReact.tmLanguage
View file
Open in desktop
Expand Up @@ -3195,7 +3195,7 @@
<key>name</key>
<string>storage.type.property.tsx</string>
<key>match</key>
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))(get|set)(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))(accessor|get|set)(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
</dict>
<key>async-modifier</key>
<dict>
Expand Down
110 changes: 110 additions & 0 deletions tests/baselines/autoAccessor.baseline.txt
View file
Open in desktop
@@ -0,0 +1,110 @@
original file
-----------------------------------
class C {
accessor a: number;
accessor b = 1;
abstract accessor c: number;
static accessor d = 1;
}

-----------------------------------

Grammar: TypeScript.tmLanguage
-----------------------------------
>class C {
^^^^^
source.ts meta.class.ts storage.type.class.ts
^
source.ts meta.class.ts
^
source.ts meta.class.ts entity.name.type.class.ts
^
source.ts meta.class.ts
^
source.ts meta.class.ts punctuation.definition.block.ts
> accessor a: number;
^^^^
source.ts meta.class.ts
^^^^^^^^
source.ts meta.class.ts storage.type.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.definition.property.ts variable.object.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.type.annotation.ts keyword.operator.type.annotation.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.type.annotation.ts
^^^^^^
source.ts meta.class.ts meta.field.declaration.ts meta.type.annotation.ts support.type.primitive.ts
^
source.ts meta.class.ts punctuation.terminator.statement.ts
> accessor b = 1;
^^^^
source.ts meta.class.ts
^^^^^^^^
source.ts meta.class.ts storage.type.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.definition.property.ts variable.object.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts keyword.operator.assignment.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts constant.numeric.decimal.ts
^
source.ts meta.class.ts punctuation.terminator.statement.ts
> abstract accessor c: number;
^^^^
source.ts meta.class.ts
^^^^^^^^
source.ts meta.class.ts storage.modifier.ts
^
source.ts meta.class.ts
^^^^^^^^
source.ts meta.class.ts storage.type.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.definition.property.ts variable.object.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.type.annotation.ts keyword.operator.type.annotation.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.type.annotation.ts
^^^^^^
source.ts meta.class.ts meta.field.declaration.ts meta.type.annotation.ts support.type.primitive.ts
^
source.ts meta.class.ts punctuation.terminator.statement.ts
> static accessor d = 1;
^^^^
source.ts meta.class.ts
^^^^^^
source.ts meta.class.ts storage.modifier.ts
^
source.ts meta.class.ts
^^^^^^^^
source.ts meta.class.ts storage.type.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts meta.definition.property.ts variable.object.property.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts keyword.operator.assignment.ts
^
source.ts meta.class.ts meta.field.declaration.ts
^
source.ts meta.class.ts meta.field.declaration.ts constant.numeric.decimal.ts
^
source.ts meta.class.ts punctuation.terminator.statement.ts
>}
^
source.ts meta.class.ts punctuation.definition.block.ts
>
^
source.ts
6 changes: 6 additions & 0 deletions tests/cases/autoAccessor.ts
View file
Open in desktop
@@ -0,0 +1,6 @@
class C {
accessor a: number;
accessor b = 1;
abstract accessor c: number;
static accessor d = 1;
}