Catch hover on as const (#43588)

* Catch hover on as const * Update test based on feedback
microsoft · Apr 12, 2021 · 0487b38 · 0487b38
1 parent 5d8a4a1
commit 0487b38
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -1670,7 +1670,7 @@ namespace ts {
         function shouldGetType(sourceFile: SourceFile, node: Node, position: number): boolean {
             switch (node.kind) {
                 case SyntaxKind.Identifier:
-                    return !isLabelName(node) && !isTagName(node);
+                    return !isLabelName(node) && !isTagName(node) && !isConstTypeReference(node.parent);
                 case SyntaxKind.PropertyAccessExpression:
                 case SyntaxKind.QualifiedName:
                     // Don't return quickInfo if inside the comment in `a/**/.b`

diff --git a/tests/cases/fourslash/quickInfoForConstTypeReference.ts b/tests/cases/fourslash/quickInfoForConstTypeReference.ts
@@ -0,0 +1,5 @@
+/// <reference path="fourslash.ts" />
+
+////"" as /**/const;
+
+verify.not.quickInfoExists();