fix(50415): clone props for get/set accessors

microsoft · Aug 26, 2022 · bd27b3b · bd27b3b
1 parent c4eb37c
commit bd27b3b
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 4 deletions.
diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
@@ -124,11 +124,11 @@ namespace ts.codefix {
                 for (const accessor of orderedAccessors) {
                     if (isGetAccessorDeclaration(accessor)) {
                         addClassElement(factory.createGetAccessorDeclaration(
-                            modifiers,
-                            name,
+                            getSynthesizedDeepClones(modifiers),
+                            getSynthesizedDeepClone(name),
                             emptyArray,
-                            typeNode,
-                            ambient ? undefined : body || createStubbedMethodBody(quotePreference)));
+                            getSynthesizedDeepClone(typeNode),
+                            ambient ? undefined : getSynthesizedDeepClone(body) || createStubbedMethodBody(quotePreference)));
                     }
                     else {
                         Debug.assertNode(accessor, isSetAccessorDeclaration, "The counterpart to a getter should be a setter");

diff --git a/tests/cases/fourslash/completionsOverridingMethod15.ts b/tests/cases/fourslash/completionsOverridingMethod15.ts
@@ -0,0 +1,27 @@
+/// <reference path="fourslash.ts" />
+
+// @newline: LF
+////declare class B {
+////    get foo(): any;
+////    set foo(value: any);
+////}
+////class A extends B {
+////    /**/
+////}
+
+verify.completions({
+    marker: "",
+    preferences: {
+        includeCompletionsWithInsertText: true,
+        includeCompletionsWithSnippetText: false,
+        includeCompletionsWithClassMemberSnippets: true,
+    },
+    includes: [
+        {
+            name: "foo",
+            sortText: completion.SortText.ClassMemberSnippets,
+            insertText: "get foo(): any {\n}\nset foo(value: any) {\n}",
+        }
+    ],
+    isNewIdentifierLocation: true
+})