Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Emit error on class fields named "constructor"
- Loading branch information
1 parent
9f601ff
commit e81fa21
Showing
7 changed files
with
85 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
tests/baselines/reference/propertyNamedConstructor.errors.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
tests/cases/conformance/classes/propertyMemberDeclarations/propertyNamedConstructor.ts(2,3): error TS18006: Classes may not have a field named 'constructor'. | ||
|
||
|
||
==== tests/cases/conformance/classes/propertyMemberDeclarations/propertyNamedConstructor.ts (1 errors) ==== | ||
class X1 { | ||
"constructor" = 3; // Error | ||
~~~~~~~~~~~~~ | ||
!!! error TS18006: Classes may not have a field named 'constructor'. | ||
} | ||
|
||
class X2 { | ||
["constructor"] = 3; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
//// [propertyNamedConstructor.ts] | ||
class X1 { | ||
"constructor" = 3; // Error | ||
} | ||
|
||
class X2 { | ||
["constructor"] = 3; | ||
} | ||
|
||
|
||
//// [propertyNamedConstructor.js] | ||
var X1 = /** @class */ (function () { | ||
function X1() { | ||
this["constructor"] = 3; // Error | ||
} | ||
return X1; | ||
}()); | ||
var X2 = /** @class */ (function () { | ||
function X2() { | ||
this["constructor"] = 3; | ||
} | ||
return X2; | ||
}()); |
16 changes: 16 additions & 0 deletions
16
tests/baselines/reference/propertyNamedConstructor.symbols
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
=== tests/cases/conformance/classes/propertyMemberDeclarations/propertyNamedConstructor.ts === | ||
class X1 { | ||
>X1 : Symbol(X1, Decl(propertyNamedConstructor.ts, 0, 0)) | ||
|
||
"constructor" = 3; // Error | ||
>"constructor" : Symbol(X1["constructor"], Decl(propertyNamedConstructor.ts, 0, 10)) | ||
} | ||
|
||
class X2 { | ||
>X2 : Symbol(X2, Decl(propertyNamedConstructor.ts, 2, 1)) | ||
|
||
["constructor"] = 3; | ||
>["constructor"] : Symbol(X2["constructor"], Decl(propertyNamedConstructor.ts, 4, 10)) | ||
>"constructor" : Symbol(X2["constructor"], Decl(propertyNamedConstructor.ts, 4, 10)) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
=== tests/cases/conformance/classes/propertyMemberDeclarations/propertyNamedConstructor.ts === | ||
class X1 { | ||
>X1 : X1 | ||
|
||
"constructor" = 3; // Error | ||
>"constructor" : number | ||
>3 : 3 | ||
} | ||
|
||
class X2 { | ||
>X2 : X2 | ||
|
||
["constructor"] = 3; | ||
>["constructor"] : number | ||
>"constructor" : "constructor" | ||
>3 : 3 | ||
} | ||
|
7 changes: 7 additions & 0 deletions
7
tests/cases/conformance/classes/propertyMemberDeclarations/propertyNamedConstructor.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class X1 { | ||
"constructor" = 3; // Error | ||
} | ||
|
||
class X2 { | ||
["constructor"] = 3; | ||
} |