Skip to content

Commit

Permalink
Merge pull request #29591 from Microsoft/removeUnnecessaryDeclarations
Browse files Browse the repository at this point in the history
Do not generate dts files for tsc/tsserver and such when we do not use it at all.
  • Loading branch information
sheetalkamat committed Jan 25, 2019
2 parents 4da9d8b + e51a2fe commit fa74cef
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Gulpfile.js
Expand Up @@ -138,7 +138,7 @@ gulp.task(typescriptServicesProject, /*help*/ false, () => {
compilerOptions: {
"removeComments": false,
"stripInternal": true,
"declarationMap": false,
"declaration": true,
"outFile": "typescriptServices.out.js" // must align with same task in jakefile. We fix this name below.
}
});
Expand Down
2 changes: 1 addition & 1 deletion Jakefile.js
Expand Up @@ -361,7 +361,7 @@ file(ConfigFileFor.tsserverLibrary, [], function () {
compilerOptions: {
"removeComments": false,
"stripInternal": true,
"declarationMap": false,
"declaration": true,
"outFile": "tsserverlibrary.out.js"
}
})
Expand Down
2 changes: 1 addition & 1 deletion src/cancellationToken/tsconfig.json
@@ -1,5 +1,5 @@
{
"extends": "../tsconfig-base",
"extends": "../tsconfig-noncomposite-base",
"compilerOptions": {
"outDir": "../../built/local/",
"rootDir": ".",
Expand Down
2 changes: 1 addition & 1 deletion src/testRunner/tsconfig.json
@@ -1,5 +1,5 @@
{
"extends": "../tsconfig-base",
"extends": "../tsconfig-noncomposite-base",
"compilerOptions": {
"outFile": "../../built/local/run.js",
"composite": false,
Expand Down
2 changes: 1 addition & 1 deletion src/tsc/tsconfig.json
@@ -1,5 +1,5 @@
{
"extends": "../tsconfig-base",
"extends": "../tsconfig-noncomposite-base",
"compilerOptions": {
"outFile": "../../built/local/tsc.js"
},
Expand Down
8 changes: 8 additions & 0 deletions src/tsconfig-noncomposite-base.json
@@ -0,0 +1,8 @@
{
"extends": "./tsconfig-base",
"compilerOptions": {
"declaration": false,
"declarationMap": false,
"composite": false
}
}
2 changes: 1 addition & 1 deletion src/tsserver/tsconfig.json
@@ -1,5 +1,5 @@
{
"extends": "../tsconfig-base",
"extends": "../tsconfig-noncomposite-base",

"compilerOptions": {
"outFile": "../../built/local/tsserver.js",
Expand Down
2 changes: 1 addition & 1 deletion src/typingsInstaller/tsconfig.json
@@ -1,5 +1,5 @@
{
"extends": "../tsconfig-base",
"extends": "../tsconfig-noncomposite-base",
"compilerOptions": {
"removeComments": true,
"outFile": "../../built/local/typingsInstaller.js",
Expand Down
4 changes: 2 additions & 2 deletions src/watchGuard/tsconfig.json
@@ -1,5 +1,5 @@
{
"extends": "../tsconfig-base",
"extends": "../tsconfig-noncomposite-base",
"compilerOptions": {
"removeComments": true,
"outFile": "../../built/local/watchGuard.js",
Expand All @@ -13,4 +13,4 @@
"files": [
"watchGuard.ts"
]
}
}

0 comments on commit fa74cef

Please sign in to comment.