Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't pass --skipLibCheck at command line when using --build #41185

Closed
dinofx opened this issue Oct 21, 2020 · 3 comments
Closed

can't pass --skipLibCheck at command line when using --build #41185

dinofx opened this issue Oct 21, 2020 · 3 comments
Labels
Working as Intended The behavior described is the intended behavior; this is not a bug

Comments

@dinofx
Copy link

dinofx commented Oct 21, 2020

error TS5072: Unknown build option '--skipLibCheck'.

During development, my team uses a tsc watch task on a root tsconfig config that pulls in many other "project" tsconfigs. Only during a development/watch build, we would like all of these projects to be built with skipLibCheck true, since it is ~5 times faster.

The only way to do this seems to be to duplicate every tsconfig file (over 25 files), since the CLI doesn't support passing this option through to the references projects' tsconfigs.

@MartinJohns
Copy link
Contributor

Please respect the issue templates for bug reports and feature requests. :-) This will make the work for the TypeScript team much easier and they can focus on improving the language, instead of deciphering GitHub issues.


This is a duplicate of #25613.

@RyanCavanaugh RyanCavanaugh added the Working as Intended The behavior described is the intended behavior; this is not a bug label Oct 22, 2020
@RyanCavanaugh
Copy link
Member

👆

@dinofx
Copy link
Author

dinofx commented Oct 22, 2020

@RyanCavanaugh thanks, I'm aware of the due diligence expected when opening an issue. (I was an eclipse project lead for several years). I did try searching for skipLibCheck for a duplicate issues (even closed ones). If I had found "Allow regular flags to mix with --build", I would have gone out and bought a lottery ticket.

MarcCelani-at added a commit to MarcCelani-at/TypeScript that referenced this issue Sep 2, 2021
Summary:
Many large composite projects rely on skipLibCheck to improve build times.
However, skipLibCheck does introduce some risk that projects miss typescript errors
in new node module versions they install.

This is in response to Issues microsoft#45691, microsoft#25613, and microsoft#41185

Test Plan:
New tsbuild unit test scenario that tests overriding the skipLibCheck value with a flag.
Validated with verbose output that the actual build overrode the value in the tsconfig.json file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Working as Intended The behavior described is the intended behavior; this is not a bug
Projects
None yet
Development

No branches or pull requests

3 participants