Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --skipLibCheck flag in tsbuild #45698

Closed
wants to merge 0 commits into from

Conversation

MarcCelani-at
Copy link

Summary:
Many large composite projects rely on skipLibCheck to improve build times.
However, skipLibCheck does introduce some risk that projects miss typescript errors
in new node module versions they install.

This is in response to Issues #45691, #25613, and #41185

This issue is not tagged with Backlog, but I'd request that it be considered anyway. Reason being: is an issue with many duplicates and a long history of discussion. I don't believe that this change should be controversial.

[ ] There is an associated issue in the Backlog milestone (required)
[x] Code is up-to-date with the main branch
[x] You've successfully run gulp runtests locally
[x] There are new or updated unit tests validating the change

Test Plan:
New tsbuild unit test scenario that tests overriding the skipLibCheck value with a command line argument.
Validated with verbose output that the actual build overrode the value in the tsconfig.json file.

Fixes #25613 (partially), #45691, and #41185

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 2, 2021
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #25613. If you can get it accepted, this PR will have a better chance of being reviewed.

@sandersn sandersn added this to Not started in PR Backlog Sep 21, 2021
@MarcCelani-at
Copy link
Author

Is there any interest in this PR? I'm happy to resolve conflicts if so.

@sandersn
Copy link
Member

sandersn commented Nov 8, 2021

The hard part of this issue is figuring out the semantics. I'd rather wait on this PR until we've decided on that in the issue discussion. Probably closing it makes the most sense since it's not much code and may well code-rot in the meantime.

@sandersn sandersn moved this from Not started to Waiting on author in PR Backlog Nov 8, 2021
PR Backlog automation moved this from Waiting on author to Done Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

Allow regular flags to mix with --build
3 participants