Improved lookahead for arrow functions. #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #34. Specifically: * We no longer automatically assume "()" is a function expression. It must be followed by an arrow, colon, or curly brace. * If an arrow is missing following a signature, but a curly brace is present, we assume the user forgot the arrow and try to parse the body anyway.
| // We had "(" not followed by an identifier. This definitely doesn't | ||
| // look like a lambda. Note: we could be a little more lenient and allow | ||
| // "(public" or "(private". These would not ever actually be allowed, | ||
| // but we could provide a good error message instead of bailing out. | ||
| if (!isIdentifier()) { |
There was a problem hiding this comment.
Why did tihs comment move outside of the block that it is relevant to?
There was a problem hiding this comment.
Felt like it would be more consistent since all the other comment blocks reside outside the checks. I'm feeling against it now.
There was a problem hiding this comment.
Actually, with different phrasing, I think it might be fine.
Specifically where we have a full signature followed by an open curly brace.
| var sig = parseSignature(SyntaxKind.CallSignature, SyntaxKind.ColonToken); | ||
| parseExpected(SyntaxKind.EqualsGreaterThanToken); | ||
| return sig; | ||
| if (token === SyntaxKind.EqualsGreaterThanToken || token === SyntaxKind.OpenBraceToken) { |
There was a problem hiding this comment.
looks good. could you add a comment here why having a colon isn't enogh. i.e. the ambiguity with:
a ? (b) : ...
thanks!
| !!! ';' expected. | ||
| ~ | ||
| !!! Cannot find name 'x'. | ||
| !!! '=>' expected. |
DanielRosenwasser
added a commit
that referenced
this pull request
Jul 25, 2014
Improved lookahead for arrow functions.
This was referenced Jul 25, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #34.
Specifically: