Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix narrow type of relax compare #25174

Closed
wants to merge 1 commit into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jun 23, 2018

Fixes #24991

This pr adds a new relation called relaxComparableRelation, that compare type in a non strict equal conpare

this is not finished yet, follow item need to fix:

  1. value compare of literal
  2. object type compare
  3. format code and simply logic predicate

@RyanCavanaugh
Copy link
Member

Closing for housekeeping. As an aside, I'm not sure we'd want the PR as-is -- new relations are another cache we need to fill. Hopefully there would be another fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid type coercion with == operator and strings
2 participants