New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check more case for empty binding patten #25263
check more case for empty binding patten #25263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix spelling and merge conflicts. Thanks!
src/compiler/checker.ts
Outdated
if (strictNullChecks && node.name.elements.length === 0) { | ||
checkNonNullType(initializerType, node); | ||
const needCheckInitializer = node.initializer && node.parent.parent.kind !== SyntaxKind.ForInStatement; | ||
const needCheckWinendType = node.name.elements.length === 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling
@Kingwl ping on this one - would be ready to merge after fixes |
🙋🏻♂️ |
@Kingwl I promise to merge after the conflict is resolved! 👋 |
@typescript-bot test this. |
2acf313
to
d88c01e
Compare
Fixes #24634