New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolveName: remove useless case #28669
resolveName: remove useless case #28669
Conversation
PropertySignature cannot occur in a class. The condition inside the clause required the parent to be a class, so it was never true. This removes the case clause and the part of the condition that is now useless.
@typescript-bot test this because I'm paranoid |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 19a5db2. You can monitor the build here. It should now contribute to this PR's status checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RWC appears to have some incorrect regressions of the form:
import Foo from './Foo';
~~~~~~~~~~~~~~~~~~~~~~~
!!! error TS6133: 'Foo' is declared but its value is never read.
export default class Bar {
static Blah: typeof Foo;
}
I cannot reproduce that error locally. It's strange that this change caused new errors at all. There must be something else going wrong. Is it possible to view the code that has new errors or are these private projects? |
@typescript-bot test this |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 19a5db2. You can monitor the build here. It should now contribute to this PR's status checks. |
We'll try again. If the error's still there I'll try to get a usable repro - the code in those suites is mostly not shareable due to not being public. |
@typescript-bot test this again? |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 19a5db2. You can monitor the build here. It should now contribute to this PR's status checks. |
Pushed up a newer copy of master to your fork, which it turns out is required. Rerunning tests @typescript-bot test this |
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 153538f. You can monitor the build here. It should now contribute to this PR's status checks. |
PropertySignature cannot occur in a class.
The condition inside the clause required the parent to be a class, so it was never true.
This removes the case clause and the part of the condition that is now useless.