Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom error message when trying to assign constraint type to generic type parameter #30394

Merged
merged 5 commits into from Apr 30, 2019
Merged

Added custom error message when trying to assign constraint type to generic type parameter #30394

merged 5 commits into from Apr 30, 2019

Commits on Jan 15, 2019

  1. Added custom error message when trying to assign constraint type to g… 

    …eneric type parameter

Fixes microsoft#29049.

This also adds the new message in chained error messages. `typeParameterDiamond4.errors.txt` shows it appearing twice in the "diamond" scenario. I can't tell if this severely increased amount of nested messages is good or bad...?
    Josh Goldberg committed Jan 15, 2019
    Copy the full SHA
    54ede16 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Merge branch 'master'

    Josh Goldberg committed Mar 18, 2019
    Copy the full SHA
    4ba127c View commit details
    Browse the repository at this point in the history

  2. Updated diagnostic message per suggestion

    Josh Goldberg committed Mar 18, 2019
    Copy the full SHA
    9323c7a View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Merge branch 'master' into generic-assignability-diagnostic 

    # Conflicts:
#	src/compiler/diagnosticMessages.json
#	tests/baselines/reference/functionTypeArgumentAssignmentCompat.errors.txt
#	tests/baselines/reference/genericFunctionCallSignatureReturnTypeMismatch.errors.txt
#	tests/baselines/reference/mappedTypeRelationships.errors.txt
    @RyanCavanaugh
    RyanCavanaugh committed Apr 25, 2019
    Copy the full SHA
    565cfd6 View commit details
    Browse the repository at this point in the history

  2. Align formatting with local custom

    @RyanCavanaugh
    RyanCavanaugh committed Apr 25, 2019
    Copy the full SHA
    60c4126 View commit details
    Browse the repository at this point in the history