Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop: module.exports alias detection #31436

Merged
merged 3 commits into from May 17, 2019
Merged

Fix infinite loop: module.exports alias detection #31436

merged 3 commits into from May 17, 2019

Commits on May 16, 2019

  1. Fix infinite loop: module.exports alias detection 

    Previously, module.exports alias detection in the binder could enter an
infinite recursion. Now it does not.

Notably, there are *two* safeguards: a counter limiter that I set at
100, and an already-seen set. I actually prefer the counter limiter code
because it's foolproof and uses less memory. But it takes 100
iterations to escape from loops.
    @sandersn
    sandersn committed May 16, 2019
    Copy the full SHA
    55e2731 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. fix space lint

    @sandersn
    sandersn committed May 17, 2019
    Copy the full SHA
    0c68f02 View commit details
    Browse the repository at this point in the history

  2. Remove already-seen map

    @sandersn
    sandersn committed May 17, 2019
    Copy the full SHA
    8f4712e View commit details
    Browse the repository at this point in the history