Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JS with isolated modules #31483

Merged
merged 4 commits into from May 23, 2019
Merged

Allow JS with isolated modules #31483

merged 4 commits into from May 23, 2019

Commits on May 20, 2019

  1. Allow JS with isolated modules 

    Previously legacy JS code was not allowed; it was required to use ES6
module syntax. Unfortunately, the check happens after parsing but before
binding, and the commonjs module indicator isn't set until binding
because it's not syntactically simple like the ES6 module indicator,
which is set during parsing.

So I decided that JS should be allowed during isolatedModules
unconditionally. We're not going to be transforming it anyway.
    @sandersn
    sandersn committed May 20, 2019
    Copy the full SHA
    0fcb933 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Merge branch 'master' into allow-js-in-isolatedmodules

    @sandersn
    sandersn committed May 21, 2019
    Copy the full SHA
    608292b View commit details
    Browse the repository at this point in the history

  2. Update baselines

    @sandersn
    sandersn committed May 21, 2019
    Copy the full SHA
    b837aae View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. Switch test to outDir instead of noEmit

    @sandersn
    sandersn committed May 23, 2019
    Copy the full SHA
    d73fd29 View commit details
    Browse the repository at this point in the history