Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 User test baselines have changed #32267

Conversation

typescript-bot
Copy link
Collaborator

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @weswigham @sandersn @RyanCavanaugh

@weswigham
Copy link
Member

cc @rbuckton you look over these changes form the generator types PR yet?

@rbuckton
Copy link
Member

rbuckton commented Jul 5, 2019

I reviewed them following an on-demand run, but I'm not certain how to proceed. Do I accept these changes as is, or do I need to submit issues against the user test repositories for errors? The majority of changes are due to outdated NodeJS definitions.

@weswigham
Copy link
Member

It's up to us - if updating these projects for their maintainers is too cumbersome, we can accept the baseline (which just means merging this PR), but that does lower how clean the baselines are and how easy it is to identify future change. Plus, at least for the rush-build projects the error blocks the build, which really hurts the test value :P

@weswigham weswigham closed this Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants