Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/es2015): Move Promise.race(Iterable) to es2015.iterable.d.ts #36435

Closed

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jan 25, 2020

#31117 caused an issue where the Promise.race overload that takes an Iterable argument was in es2015.promise.d.ts instead of being in es2015.iterable.d.ts.


Fixes #31722
Supersedes and closes #36368

@falsandtru
Copy link
Contributor

See #36368

@sandersn sandersn added this to Nostrum in Pall Mall Jan 28, 2020
@sandersn sandersn moved this from Nostrum to Gallery in Pall Mall Jan 28, 2020
@sandersn sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 1, 2020
@falsandtru
Copy link
Contributor

falsandtru commented Feb 1, 2020

Note that this PR has the following unapproved change:

-    all<TAll>(values: Iterable<TAll | PromiseLike<TAll>>): Promise<TAll[]>;
+    all<T>(values: Iterable<T>): Promise<(T extends PromiseLike<infer U> ? U : T)[]>;

#36368 is the conservative original PR.

@sandersn sandersn added this to Not started in PR Backlog Feb 3, 2020
@sandersn sandersn added For Backlog Bug PRs that fix a backlog bug and removed For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 4, 2020
@sandersn sandersn moved this from Gallery to Curio in Pall Mall Mar 4, 2020
@sandersn sandersn removed this from Curio in Pall Mall Mar 9, 2020
@sandersn sandersn moved this from Not started to Needs review in PR Backlog Mar 9, 2020
@sandersn sandersn self-assigned this Mar 10, 2020
PR Backlog automation moved this from Needs review to Done Mar 20, 2020
@rbuckton
Copy link
Member

We are pushing awaited until after TS3.9 while we continue to assess the impact of the change. While this means we are essentially reverting #35998 with #37610, #37610 leaves in place the change that addressed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

[3.5.1] Iterable is missing in lib.es2015.promise.d.ts
4 participants