Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle getScriptVersion correctly to ensure program structure is checked correctly #36808

Merged
merged 6 commits into from Feb 26, 2020
Merged

Handle getScriptVersion correctly to ensure program structure is checked correctly #36808

merged 6 commits into from Feb 26, 2020

Conversation

sheetalkamat
Copy link
Member

Fixes #36748

@sheetalkamat
Fix tests when there are project references but has disableSourceOfPr…
4382d1c 
…ojectReferenceRedirect
@sheetalkamat
Handle getScriptVersion correctly to ensure program structure is chec…
0952bf7 
…ked correctly

Fixes #36748
@sheetalkamat
Harness's language service host doesnt have getProjectVersion.
d5e5b79 
This means earlier we were creating fresh program everytime we did LS operation
Now we reuse same program, so quick info depends on order of quickinfo demands
@sheetalkamat
Because same program is used, it unvails a bug that if export= is e…
05ccdcf 
…valuated before finding references, it cant find all definitions from the merge
sandersn
sandersn reviewed Feb 19, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context to understand this change. From the bug, it sounds like the fix applies to language service API users. Does it affect our usage of the language service too?

src/server/editorServices.ts Outdated Show resolved Hide resolved
src/server/editorServices.ts Show resolved Hide resolved
src/server/project.ts Outdated Show resolved Hide resolved
src/server/scriptInfo.ts Show resolved Hide resolved
tests/cases/fourslash/findAllRefs_importType_js.ts Show resolved Hide resolved
sheetalkamat and others added 2 commits February 24, 2020 12:42
@sheetalkamat @sandersn
Update src/server/project.ts
5de007c 
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@sheetalkamat
Make clearSourceMapperCache required
252ba7f
@sheetalkamat sheetalkamat mentioned this pull request Feb 24, 2020
Open
@sheetalkamat
Copy link
Member Author

@sandersn have resolved all the comments.. Please take a look.. thanks

@sheetalkamat sheetalkamat merged commit e89df5c into master Feb 26, 2020
@sheetalkamat sheetalkamat deleted the isUptoDate branch February 26, 2020 00:11
@jakebailey jakebailey mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@amcasey amcasey Awaiting requested review from amcasey

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

@orta orta Awaiting requested review from orta

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@sandersn sandersn

@sheetalkamat sheetalkamat

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isProgramUpToDate reports false because it expects HostCache to include typescript/lib/*.d.ts files
3 participants
@sheetalkamat @sandersn @typescript-bot