Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid unused property renaming in destructuring binding in function types #41044

Merged
merged 31 commits into from Jun 14, 2022
Merged

Forbid unused property renaming in destructuring binding in function types #41044

merged 31 commits into from Jun 14, 2022

Commits on Jun 8, 2022

  1. Forbid renaming a propertyin function type parameters

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    4aec8ef View commit details
    Browse the repository at this point in the history

  2. add tests

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    a37d6d4 View commit details
    Browse the repository at this point in the history

  3. Remove renaming from declaration output

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    67732d3 View commit details
    Browse the repository at this point in the history

  4. accept baseline

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    1d114e6 View commit details
    Browse the repository at this point in the history

  5. accept baseline

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    4abcfa1 View commit details
    Browse the repository at this point in the history

  6. renew tests (not very right now)

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    39e90ce View commit details
    Browse the repository at this point in the history

  7. get correct result

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    79ef4fd View commit details
    Browse the repository at this point in the history

  8. update diagnostic text

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    69b8a58 View commit details
    Browse the repository at this point in the history

  9. accept baseline

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    4ddd9ae View commit details
    Browse the repository at this point in the history

  10. add declaration emit test

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    e210484 View commit details
    Browse the repository at this point in the history

  11. fix declaration emit

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    2797958 View commit details
    Browse the repository at this point in the history

  12. fix formatting

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    cb326d2 View commit details
    Browse the repository at this point in the history

  13. revert unnecessary change

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    17a29ff View commit details
    Browse the repository at this point in the history

  14. accept baseline

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    c4c80db View commit details
    Browse the repository at this point in the history

  15. extend tests

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    1e3dc2e View commit details
    Browse the repository at this point in the history

  16. Revert "revert unnecessary change" 

    This reverts commit 17a29ff.
    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    32c340e View commit details
    Browse the repository at this point in the history

  17. accept baseline

    @uhyo
    uhyo committed Jun 8, 2022
    Copy the full SHA
    9c9fe5e View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Rename and refactor potentialAlways... stuff

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    f0e5112 View commit details
    Browse the repository at this point in the history

  2. add non-identifier names

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    7aa2b6e View commit details
    Browse the repository at this point in the history

  3. extend check to non-identifier original property names

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    755c7c4 View commit details
    Browse the repository at this point in the history

  4. update diagnostic message

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    c7768cf View commit details
    Browse the repository at this point in the history

  5. add related span

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    bdb42e1 View commit details
    Browse the repository at this point in the history

  6. accept baseline

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    6d4d147 View commit details
    Browse the repository at this point in the history

  7. add symbol-keyed test case

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    bc92945 View commit details
    Browse the repository at this point in the history

  8. oops?

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    e2710b7 View commit details
    Browse the repository at this point in the history

  9. workaround for unstable test

    @uhyo
    uhyo committed Jun 9, 2022
    Copy the full SHA
    1e4c14b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. fix suggested name

    @uhyo
    uhyo committed Jun 10, 2022
    Copy the full SHA
    4e519ff View commit details
    Browse the repository at this point in the history

  2. add comment about non-identifier property names

    @uhyo
    uhyo committed Jun 10, 2022
    Copy the full SHA
    07f162f View commit details
    Browse the repository at this point in the history

  3. simplify isReferenced check

    @uhyo
    uhyo committed Jun 10, 2022
    Copy the full SHA
    6c8a95b View commit details
    Browse the repository at this point in the history

  4. accept baseline

    @uhyo
    uhyo committed Jun 10, 2022
    Copy the full SHA
    bd0da30 View commit details
    Browse the repository at this point in the history

  5. move it one step further

    @uhyo
    uhyo committed Jun 10, 2022
    Copy the full SHA
    600b614 View commit details
    Browse the repository at this point in the history