New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflows): bump 'setup-node' to v2 and use 'cache' option #44924
Conversation
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
馃憤馃徑 Ok to remove indentation.
If I'm understanding correctly:
What I suggest to do is:
Let me know what do you think @weswigham and @RyanCavanaugh |
@weswigham you reviewed #44897; this is the followup to that. |
My comment from the other PR - about needing cache-busting for certain packages that we pin to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to make the current status of the PR explicit.
@oscard0m is @weswigham's request feasible for you to do? I don't think we'll able to take this PR without it. =( |
From what I've read in I just created an issue to @weswigham |
After a bit of research on I keep waiting for your feedback regarding the other actions not uninstalling packages as a step. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just gunna close this and someone can come forward with another version that does cache busting where needed. Or not; this isn't exactly a high priority thing. |
Description
cache
to workflows usingactions/setup-node
actions/setup-node
tov2
to give support to thiscache
optionContext
setup-node
GitHub Action just released a new option to add cache to steps using it.You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
Fix #44898
馃 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 馃挭馃従
Migrated from #44897 due to indentation changes problem (GitHub was still showing indentation changes even I was restoring back the original indentation)