Adds 'Awaited' type alias and updates to Promise.all/race/allSettled/any #45350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
|
@typescript-bot perf test |
|
Heya @rbuckton, I've started to run the perf test suite on this PR at 46ce88c. You can monitor the build here. Update: The results are in! |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
Interesting outcomes from the rwc tests:
|
|
@rbuckton Here they are:Comparison Report - main..45350
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The OOM in Prettier doesn't seem to be related to this change, as I'm seeing it in other unrelated PRs as well. |
|
Notes from design meeting:
|
|
I investigated whether having |
|
Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
rbuckton
force-pushed
the
awaitedTypeAlias
branch
from
6fd4ca8
to
6703b9f
Compare
rbuckton
force-pushed
the
awaitedTypeAlias
branch
from
6703b9f
to
d83915c
Compare
andrewbranch
approved these changes
Sep 9, 2021
ExE-Boss
reviewed
Sep 15, 2021
Comment on lines
+1453
to
+1454
| T : // argument was not an object | ||
| T; // non-thenable |
There was a problem hiding this comment.
I believe that these comments are swapped.
There was a problem hiding this comment.
Apparently so. I will push up a small fix.
I did a quick search for To check usages of |
This was referenced Nov 3, 2021
|
Hello everyone, Not sure if this is the correct place to bring this up but the For reference, here is what /**
* Recursively unwraps the "awaited type" of a type. Non-promise "thenables" should resolve to `never`. This emulates the behavior of `await`.
*/
type Awaited<T> =
T extends null | undefined ? T : // special case for `null | undefined` when not in `--strictNullChecks` mode
T extends object & { then(onfulfilled: infer F): any } ? // `await` only unwraps object types with a callable `then`. Non-object types are not unwrapped
F extends ((value: infer V) => any) ? // if the argument to `then` is callable, extracts the argument
Awaited<V> : // recursively unwrap the value
never : // the argument to `then` was not callable
T; // non-object or non-thenableThe problem is that we have a custom Promise class ( Our public then<TResult1 = T, TResult2 = never>(
onfulfilled?: ((value: T, abortController: AbortController) => TResult1 | PromiseLike<TResult1>) | undefined | null,
onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | undefined | null
): AbortablePromise<TResult1 | TResult2>;So Hence, Would it be possible to make the type condition more flexible in |
This was referenced Mar 18, 2022
|
It would be helpful to add some documentation about this on the Utility types page, not just in the 4.5 release notes that aren't part of the docs search. |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
Awaited<T>type alias that supports the following capabilities:PromiseLike(to avoid issues with augmentation/assignability)nevernullandundefinedin non-strictNullChecks modeThis also adds overloads to
Promise.all,Promise.race,Promise.allSettled, andPromise.anyto leverageAwaited<T>.Supersedes #33707, thanks @jablko for your prior work on this.
Fixes #27711
Fixes #22469
Fixes #28427
Fixes #30390
Fixes #31722
Fixes #33559
Fixes #33562
Fixes #33752
Fixes #34924
Fixes #34937
Fixes #35136
Fixes #35258