Add error on new module/moduleResolution modes when used in non-nightly TS #46557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
DanielRosenwasser
approved these changes
Oct 27, 2021
It definitely means that the publishing process will have another step of updating baselines - I actually don't know if the bot will succeed in the usual update process it does. What you could do is change the version string to |
|
https://github.com/microsoft/TypeScript/pull/42921/files maybe it'll just work if you also change the tag to |
|
I'll do it separately. |
|
Can't do it that way because that would break nightly publish - a bunch of tests would fail because they would stop having the error. |
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
…ly TS (microsoft#46557) * Add error on new module/moduleResolution modes when used in non-nightly TS * Update diagnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it depends on
ts.version, it's not exactly stable to test in our usual test harness; specifically, our defaultversionstring includes-dev, however when this hits the beta/rc/release branch, we should see a swath of baselines that test these options suddenly change and add the error. That's... maybe a good thing? I'm on the fence about it.Fixes #46454