Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This types for all methods #46672

Closed
wants to merge 2 commits into from
Closed

This types for all methods #46672

wants to merge 2 commits into from

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Nov 3, 2021

Just an experiment to see how slow it is.

@sandersn
All method signatures now have this:this
22fa978 
Except I've done it wrong, so it doesn't work yet.
@sandersn
Accept baselines
70447cb 
And the code is still wrong!
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 3, 2021
@sandersn
Copy link
Member Author

sandersn commented Nov 3, 2021

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 3, 2021 •
edited

Heya @sandersn, I've started to run the perf test suite on this PR at 70447cb. You can monitor the build here.

Update: The results are in!

@sandersn
Copy link
Member Author

sandersn commented Nov 3, 2021

Would fix #44513 if it worked and weren't too slow.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46672

Metric main 46672 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 354,497k (± 0.02%) 357,467k (± 0.03%) +2,970k (+ 0.84%) 357,268k 357,718k
Parse Time 1.95s (± 0.73%) 1.95s (± 0.42%) -0.01s (- 0.41%) 1.93s 1.97s
Bind Time 0.85s (± 0.68%) 0.84s (± 1.10%) -0.00s (- 0.59%) 0.82s 0.87s
Check Time 5.48s (± 0.39%) 5.84s (± 0.29%) +0.36s (+ 6.55%) 5.80s 5.87s
Emit Time 5.87s (± 0.41%) 5.88s (± 0.88%) +0.01s (+ 0.17%) 5.77s 5.96s
Total Time 14.15s (± 0.24%) 14.51s (± 0.31%) +0.36s (+ 2.52%) 14.41s 14.62s
Compiler-Unions - node (v10.16.3, x64)
Memory used 204,024k (± 0.02%) 204,187k (± 0.04%) +163k (+ 0.08%) 204,061k 204,394k
Parse Time 0.78s (± 0.74%) 0.79s (± 0.74%) +0.00s (+ 0.51%) 0.78s 0.80s
Bind Time 0.52s (± 1.28%) 0.52s (± 1.24%) +0.00s (+ 0.38%) 0.51s 0.54s
Check Time 7.84s (± 0.65%) 7.84s (± 0.79%) +0.00s (+ 0.03%) 7.68s 7.94s
Emit Time 2.47s (± 0.91%) 2.48s (± 0.94%) +0.00s (+ 0.08%) 2.44s 2.54s
Total Time 11.62s (± 0.51%) 11.63s (± 0.55%) +0.01s (+ 0.09%) 11.42s 11.71s
Monaco - node (v10.16.3, x64)
Memory used 342,422k (± 0.03%) 352,855k (± 0.01%) +10,433k (+ 3.05%) 352,818k 352,980k
Parse Time 1.48s (± 0.49%) 1.48s (± 0.38%) -0.00s (- 0.27%) 1.47s 1.49s
Bind Time 0.75s (± 0.64%) 0.75s (± 0.49%) -0.00s (- 0.13%) 0.74s 0.75s
Check Time 5.46s (± 0.59%) 5.83s (± 0.25%) +0.37s (+ 6.81%) 5.80s 5.86s
Emit Time 3.21s (± 1.01%) 3.19s (± 0.45%) -0.02s (- 0.56%) 3.16s 3.22s
Total Time 10.89s (± 0.44%) 11.24s (± 0.22%) +0.35s (+ 3.20%) 11.16s 11.28s
TFS - node (v10.16.3, x64)
Memory used 305,530k (± 0.01%) 329,908k (± 0.03%) +24,378k (+ 7.98%) 329,704k 330,070k
Parse Time 1.20s (± 0.54%) 1.19s (± 0.57%) -0.00s (- 0.33%) 1.18s 1.21s
Bind Time 0.71s (± 0.94%) 0.70s (± 0.71%) -0.01s (- 0.70%) 0.69s 0.71s
Check Time 5.02s (± 0.72%) 5.67s (± 0.42%) +0.65s (+12.91%) 5.63s 5.74s
Emit Time 3.38s (± 1.27%) 3.35s (± 1.08%) -0.03s (- 0.86%) 3.24s 3.41s
Total Time 10.31s (± 0.63%) 10.92s (± 0.47%) +0.61s (+ 5.90%) 10.76s 10.99s
material-ui - node (v10.16.3, x64)
Memory used 471,298k (± 0.01%) 471,164k (± 0.01%) -135k (- 0.03%) 471,039k 471,321k
Parse Time 1.78s (± 0.47%) 1.77s (± 0.40%) -0.01s (- 0.67%) 1.75s 1.78s
Bind Time 0.66s (± 0.79%) 0.66s (± 1.23%) -0.00s (- 0.15%) 0.65s 0.68s
Check Time 14.15s (± 0.46%) 14.29s (± 0.29%) +0.14s (+ 0.97%) 14.22s 14.40s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.59s (± 0.40%) 16.71s (± 0.19%) +0.12s (+ 0.74%) 16.65s 16.79s
xstate - node (v10.16.3, x64)
Memory used 568,907k (± 0.02%) 572,617k (± 0.01%) +3,710k (+ 0.65%) 572,353k 572,766k
Parse Time 2.55s (± 0.34%) 2.55s (± 0.23%) +0.00s (+ 0.20%) 2.54s 2.57s
Bind Time 1.01s (± 0.58%) 1.01s (± 0.40%) +0.00s (+ 0.20%) 1.00s 1.02s
Check Time 1.50s (± 0.89%) 1.54s (± 0.78%) +0.04s (+ 2.73%) 1.52s 1.58s
Emit Time 0.07s (± 3.14%) 0.07s (± 0.00%) -0.00s (- 1.41%) 0.07s 0.07s
Total Time 5.12s (± 0.30%) 5.17s (± 0.22%) +0.05s (+ 0.94%) 5.15s 5.21s
Angular - node (v12.1.0, x64)
Memory used 332,407k (± 0.03%) 335,199k (± 0.08%) +2,792k (+ 0.84%) 334,189k 335,498k
Parse Time 1.93s (± 0.52%) 1.94s (± 0.41%) +0.01s (+ 0.26%) 1.93s 1.96s
Bind Time 0.81s (± 0.73%) 0.82s (± 0.81%) +0.01s (+ 0.74%) 0.81s 0.84s
Check Time 5.27s (± 0.33%) 5.67s (± 0.41%) +0.40s (+ 7.53%) 5.64s 5.75s
Emit Time 6.10s (± 0.54%) 6.12s (± 0.75%) +0.02s (+ 0.34%) 6.01s 6.22s
Total Time 14.11s (± 0.27%) 14.54s (± 0.39%) +0.43s (+ 3.02%) 14.41s 14.70s
Compiler-Unions - node (v12.1.0, x64)
Memory used 191,396k (± 0.11%) 191,626k (± 0.04%) +230k (+ 0.12%) 191,468k 191,835k
Parse Time 0.78s (± 1.27%) 0.78s (± 0.63%) -0.00s (- 0.26%) 0.77s 0.79s
Bind Time 0.53s (± 0.65%) 0.53s (± 1.10%) 0.00s ( 0.00%) 0.52s 0.54s
Check Time 7.29s (± 0.54%) 7.28s (± 0.42%) -0.00s (- 0.07%) 7.22s 7.35s
Emit Time 2.51s (± 0.85%) 2.48s (± 0.60%) -0.02s (- 0.96%) 2.45s 2.51s
Total Time 11.10s (± 0.45%) 11.07s (± 0.32%) -0.03s (- 0.28%) 10.98s 11.14s
Monaco - node (v12.1.0, x64)
Memory used 325,474k (± 0.05%) 335,862k (± 0.02%) +10,388k (+ 3.19%) 335,632k 335,981k
Parse Time 1.46s (± 0.42%) 1.46s (± 0.90%) +0.00s (+ 0.07%) 1.43s 1.49s
Bind Time 0.73s (± 0.71%) 0.73s (± 0.82%) -0.00s (- 0.41%) 0.71s 0.74s
Check Time 5.31s (± 0.38%) 5.66s (± 0.50%) +0.34s (+ 6.44%) 5.56s 5.71s
Emit Time 3.22s (± 0.62%) 3.21s (± 0.38%) -0.01s (- 0.37%) 3.18s 3.23s
Total Time 10.72s (± 0.26%) 11.05s (± 0.23%) +0.33s (+ 3.04%) 11.00s 11.10s
TFS - node (v12.1.0, x64)
Memory used 290,218k (± 0.02%) 314,298k (± 0.02%) +24,080k (+ 8.30%) 314,121k 314,481k
Parse Time 1.21s (± 0.39%) 1.21s (± 0.77%) +0.00s (+ 0.08%) 1.20s 1.24s
Bind Time 0.69s (± 1.08%) 0.69s (± 0.75%) -0.00s (- 0.14%) 0.68s 0.70s
Check Time 4.90s (± 0.35%) 5.56s (± 0.50%) +0.66s (+13.51%) 5.50s 5.65s
Emit Time 3.38s (± 0.76%) 3.40s (± 0.94%) +0.01s (+ 0.35%) 3.35s 3.50s
Total Time 10.18s (± 0.36%) 10.86s (± 0.42%) +0.68s (+ 6.68%) 10.75s 10.96s
material-ui - node (v12.1.0, x64)
Memory used 449,728k (± 0.08%) 450,297k (± 0.01%) +570k (+ 0.13%) 450,206k 450,381k
Parse Time 1.78s (± 0.49%) 1.78s (± 0.57%) -0.00s (- 0.11%) 1.76s 1.80s
Bind Time 0.64s (± 1.17%) 0.64s (± 0.78%) -0.00s (- 0.31%) 0.62s 0.64s
Check Time 12.76s (± 0.86%) 12.70s (± 0.31%) -0.06s (- 0.45%) 12.63s 12.84s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.17s (± 0.71%) 15.11s (± 0.30%) -0.06s (- 0.39%) 15.06s 15.28s
xstate - node (v12.1.0, x64)
Memory used 538,447k (± 1.43%) 538,226k (± 0.02%) -221k (- 0.04%) 538,044k 538,461k
Parse Time 2.48s (± 0.52%) 2.49s (± 0.63%) +0.01s (+ 0.32%) 2.46s 2.54s
Bind Time 1.04s (± 0.77%) 1.03s (± 0.78%) -0.01s (- 0.96%) 1.02s 1.05s
Check Time 1.44s (± 0.28%) 1.49s (± 0.56%) +0.05s (+ 3.20%) 1.46s 1.50s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.03s (± 0.28%) 5.07s (± 0.50%) +0.04s (+ 0.86%) 5.03s 5.14s
Angular - node (v14.15.1, x64)
Memory used 330,782k (± 0.05%) 333,644k (± 0.01%) +2,863k (+ 0.87%) 333,583k 333,677k
Parse Time 1.94s (± 0.33%) 1.94s (± 0.23%) -0.00s (- 0.00%) 1.93s 1.95s
Bind Time 0.86s (± 0.64%) 0.86s (± 0.40%) -0.00s (- 0.58%) 0.85s 0.86s
Check Time 5.38s (± 0.56%) 5.74s (± 0.17%) +0.36s (+ 6.77%) 5.72s 5.76s
Emit Time 6.16s (± 0.50%) 6.09s (± 0.65%) -0.07s (- 1.06%) 6.01s 6.19s
Total Time 14.34s (± 0.39%) 14.63s (± 0.28%) +0.29s (+ 2.04%) 14.54s 14.73s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,778k (± 0.63%) 192,923k (± 0.49%) +1,145k (+ 0.60%) 190,363k 193,630k
Parse Time 0.81s (± 1.45%) 0.81s (± 0.64%) -0.00s (- 0.25%) 0.80s 0.82s
Bind Time 0.55s (± 0.54%) 0.55s (± 0.00%) -0.00s (- 0.36%) 0.55s 0.55s
Check Time 7.37s (± 0.48%) 7.36s (± 0.47%) -0.01s (- 0.10%) 7.27s 7.43s
Emit Time 2.49s (± 1.75%) 2.47s (± 0.83%) -0.02s (- 0.60%) 2.42s 2.53s
Total Time 11.21s (± 0.57%) 11.19s (± 0.35%) -0.03s (- 0.23%) 11.13s 11.28s
Monaco - node (v14.15.1, x64)
Memory used 324,311k (± 0.01%) 334,598k (± 0.00%) +10,287k (+ 3.17%) 334,549k 334,631k
Parse Time 1.50s (± 0.47%) 1.50s (± 0.32%) +0.00s (+ 0.13%) 1.49s 1.51s
Bind Time 0.76s (± 0.63%) 0.76s (± 0.88%) 0.00s ( 0.00%) 0.75s 0.78s
Check Time 5.26s (± 0.59%) 5.67s (± 0.25%) +0.41s (+ 7.76%) 5.64s 5.70s
Emit Time 3.23s (± 0.61%) 3.21s (± 0.53%) -0.02s (- 0.50%) 3.17s 3.26s
Total Time 10.74s (± 0.43%) 11.14s (± 0.16%) +0.40s (+ 3.68%) 11.11s 11.17s
TFS - node (v14.15.1, x64)
Memory used 289,165k (± 0.00%) 313,245k (± 0.01%) +24,080k (+ 8.33%) 313,192k 313,296k
Parse Time 1.23s (± 0.47%) 1.22s (± 0.45%) -0.01s (- 0.89%) 1.21s 1.23s
Bind Time 0.73s (± 0.71%) 0.73s (± 0.84%) +0.00s (+ 0.00%) 0.72s 0.75s
Check Time 4.92s (± 0.27%) 5.55s (± 0.64%) +0.64s (+12.93%) 5.50s 5.68s
Emit Time 3.47s (± 1.06%) 3.45s (± 1.67%) -0.02s (- 0.63%) 3.28s 3.54s
Total Time 10.36s (± 0.45%) 10.95s (± 0.67%) +0.60s (+ 5.77%) 10.79s 11.14s
material-ui - node (v14.15.1, x64)
Memory used 448,324k (± 0.01%) 448,436k (± 0.01%) +112k (+ 0.02%) 448,383k 448,498k
Parse Time 1.82s (± 0.36%) 1.82s (± 0.33%) +0.00s (+ 0.22%) 1.81s 1.84s
Bind Time 0.68s (± 0.77%) 0.68s (± 0.54%) -0.00s (- 0.44%) 0.67s 0.68s
Check Time 12.75s (± 0.61%) 12.85s (± 0.46%) +0.10s (+ 0.82%) 12.71s 12.97s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.24s (± 0.53%) 15.35s (± 0.35%) +0.11s (+ 0.71%) 15.22s 15.47s
xstate - node (v14.15.1, x64)
Memory used 532,805k (± 0.01%) 539,283k (± 1.32%) +6,478k (+ 1.22%) 536,031k 568,115k
Parse Time 2.56s (± 0.42%) 2.55s (± 0.57%) -0.01s (- 0.51%) 2.52s 2.59s
Bind Time 1.16s (± 0.96%) 1.14s (± 0.93%) -0.01s (- 1.04%) 1.12s 1.17s
Check Time 1.48s (± 0.42%) 1.53s (± 0.44%) +0.05s (+ 3.72%) 1.52s 1.55s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.27s (± 0.51%) 5.30s (± 0.35%) +0.03s (+ 0.55%) 5.27s 5.35s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory8 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 46672 10
Baseline main 10

Developer Information:

Download Benchmark

@andrewbranch
Copy link
Member

Yeah. That seems expected.

@sandersn
Copy link
Member Author

sandersn commented Nov 3, 2021

Check time is 6-7% slower on class-heavy code bases.

It's possible that issuing bogus errors takes that much time — and this PR does issue bogus errors; the code isn't correct. But I doubt it.

@sandersn sandersn closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandersn @typescript-bot @andrewbranch