Jsdoc property description #49818
Closed
Jsdoc property description #49818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
weswigham
reviewed
Jul 7, 2022
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
weswigham
reviewed
Jul 12, 2022
src/compiler/checker.ts
Outdated
| const expressionType = checkExpressionCached(name.expression); | ||
| let infos = getApplicableIndexInfos(expressionType, getLiteralTypeFromPropertyName(name.name)); | ||
| if(infos.length === 0 && getIndexInfosOfType(expressionType).filter(type => type.keyType.flags & TypeFlags.TemplateLiteral || type.keyType.flags & TypeFlags.ESSymbol).length > 0){ | ||
| infos = getApplicableIndexInfos(expressionType, checkExpressionCached(name.name)); |
There was a problem hiding this comment.
Can you comment on what examples/tests you needed this case for? AFAIK, checkExpressionCached on the name of a property access doesn't usually return the literal type of the name itself, but instead returns the type of the member the name refers to, which makes this line feel kinda nonsensical, since it's indexing the left-hand side type by the type of the whole expression, which is weird.
src/compiler/checker.ts
Outdated
| const copy = createSymbol(SymbolFlags.Signature, InternalSymbolName.Index); | ||
| copy.declarations = mapDefined(infos, i => i.declaration); | ||
| copy.parent = expressionType.symbol ? expressionType.symbol : getSymbolAtLocation(copy.declarations[0].parent); | ||
| return copy; |
There was a problem hiding this comment.
Need to assign to link.resolvedSymbol before returning
danay1999
force-pushed
the
jsdocPropertyDescription
branch
from
ecfbf8b
to
924c68c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47933