Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump target up to ES2015 #50022

Closed
wants to merge 1 commit into from
Closed

Bump target up to ES2015 #50022

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Member

Wanting to see how expensive this turns out to be performance wise, since this brings in let/const.

The two changes are interesting; they're only bugs when there's var. The switch case one is... weird code and I feel like this deserves an error somehow if the target isn't going to lower to var. The other one is a logic bug where we get a key that's undefined because it hasn't been calculated yet, but we can't determine that statically.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 24, 2022
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 24, 2022 •
edited

Heya @jakebailey, I've started to run the perf test suite on this PR at 7753eae. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50022
Metric main 50022 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 360,143k (± 0.01%) 361,326k (± 0.01%) +1,183k (+ 0.33%) 361,229k 361,417k
Parse Time 2.09s (± 0.62%) 2.26s (± 0.67%) +0.17s (+ 7.98%) 2.23s 2.30s
Bind Time 0.90s (± 1.83%) 0.89s (± 0.65%) -0.01s (- 1.00%) 0.88s 0.91s
Check Time 6.02s (± 0.44%) 6.26s (± 0.39%) +0.24s (+ 4.02%) 6.21s 6.31s
Emit Time 6.14s (± 0.49%) 6.38s (± 0.48%) +0.24s (+ 3.88%) 6.33s 6.46s
Total Time 15.15s (± 0.37%) 15.79s (± 0.27%) +0.64s (+ 4.24%) 15.70s 15.89s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,931k (± 0.05%) 207,635k (± 0.04%) +704k (+ 0.34%) 207,474k 207,865k
Parse Time 0.83s (± 0.82%) 0.93s (± 0.48%) +0.09s (+11.14%) 0.92s 0.94s
Bind Time 0.53s (± 1.67%) 0.53s (± 1.40%) +0.01s (+ 1.14%) 0.52s 0.55s
Check Time 7.17s (± 0.53%) 7.41s (± 0.26%) +0.23s (+ 3.23%) 7.36s 7.44s
Emit Time 2.49s (± 1.03%) 2.59s (± 0.59%) +0.10s (+ 4.05%) 2.56s 2.62s
Total Time 11.03s (± 0.50%) 11.46s (± 0.25%) +0.43s (+ 3.88%) 11.38s 11.51s
Monaco - node (v10.16.3, x64)
Memory used 343,901k (± 0.01%) 344,329k (± 0.02%) +428k (+ 0.12%) 344,134k 344,519k
Parse Time 1.61s (± 0.60%) 1.72s (± 0.75%) +0.11s (+ 6.95%) 1.70s 1.76s
Bind Time 0.76s (± 0.53%) 0.77s (± 0.62%) +0.01s (+ 0.79%) 0.76s 0.78s
Check Time 6.04s (± 0.23%) 6.17s (± 0.35%) +0.13s (+ 2.15%) 6.10s 6.22s
Emit Time 3.30s (± 0.27%) 3.37s (± 0.71%) +0.06s (+ 1.97%) 3.34s 3.45s
Total Time 11.71s (± 0.25%) 12.02s (± 0.37%) +0.31s (+ 2.67%) 11.92s 12.16s
TFS - node (v10.16.3, x64)
Memory used 305,095k (± 0.02%) 305,448k (± 0.02%) +353k (+ 0.12%) 305,356k 305,547k
Parse Time 1.28s (± 0.69%) 1.39s (± 0.62%) +0.10s (+ 8.10%) 1.37s 1.41s
Bind Time 0.72s (± 0.83%) 0.74s (± 0.70%) +0.02s (+ 3.21%) 0.73s 0.75s
Check Time 5.45s (± 0.46%) 5.63s (± 0.64%) +0.18s (+ 3.32%) 5.57s 5.74s
Emit Time 3.42s (± 1.13%) 3.53s (± 1.05%) +0.11s (+ 3.22%) 3.45s 3.59s
Total Time 10.87s (± 0.49%) 11.29s (± 0.58%) +0.42s (+ 3.84%) 11.17s 11.47s
material-ui - node (v10.16.3, x64)
Memory used 469,350k (± 0.01%) 471,102k (± 0.01%) +1,753k (+ 0.37%) 471,027k 471,191k
Parse Time 1.83s (± 0.60%) 1.96s (± 0.39%) +0.13s (+ 6.83%) 1.94s 1.98s
Bind Time 0.69s (± 1.35%) 0.72s (± 1.06%) +0.03s (+ 4.07%) 0.69s 0.73s
Check Time 14.60s (± 0.67%) 14.77s (± 0.59%) +0.17s (+ 1.19%) 14.46s 14.89s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.12s (± 0.55%) 17.44s (± 0.50%) +0.32s (+ 1.89%) 17.13s 17.57s
xstate - node (v10.16.3, x64)
Memory used 578,024k (± 0.01%) 579,144k (± 0.01%) +1,120k (+ 0.19%) 579,062k 579,279k
Parse Time 2.60s (± 0.31%) 2.80s (± 0.34%) +0.19s (+ 7.46%) 2.78s 2.82s
Bind Time 1.03s (± 0.39%) 1.09s (± 0.92%) +0.06s (+ 6.21%) 1.08s 1.13s
Check Time 1.57s (± 0.56%) 1.65s (± 0.44%) +0.08s (+ 4.97%) 1.63s 1.66s
Emit Time 0.07s (± 3.14%) 0.08s (± 0.00%) +0.01s (+12.68%) 0.08s 0.08s
Total Time 5.27s (± 0.28%) 5.61s (± 0.32%) +0.34s (+ 6.36%) 5.57s 5.65s
Angular - node (v12.1.0, x64)
Memory used 337,717k (± 0.01%) 338,921k (± 0.09%) +1,205k (+ 0.36%) 337,767k 339,184k
Parse Time 2.09s (± 0.46%) 2.22s (± 0.93%) +0.12s (+ 5.93%) 2.18s 2.26s
Bind Time 0.86s (± 0.93%) 0.87s (± 0.92%) +0.01s (+ 1.63%) 0.85s 0.89s
Check Time 5.83s (± 0.55%) 5.99s (± 0.57%) +0.15s (+ 2.59%) 5.89s 6.06s
Emit Time 6.40s (± 0.91%) 6.56s (± 0.79%) +0.16s (+ 2.45%) 6.46s 6.68s
Total Time 15.18s (± 0.51%) 15.63s (± 0.51%) +0.45s (+ 2.96%) 15.48s 15.78s
Compiler-Unions - node (v12.1.0, x64)
Memory used 194,588k (± 0.03%) 195,057k (± 0.11%) +470k (+ 0.24%) 194,578k 195,305k
Parse Time 0.83s (± 0.67%) 0.92s (± 1.04%) +0.09s (+10.63%) 0.89s 0.93s
Bind Time 0.55s (± 0.54%) 0.56s (± 0.89%) +0.01s (+ 1.46%) 0.55s 0.57s
Check Time 6.75s (± 0.51%) 6.85s (± 0.30%) +0.10s (+ 1.54%) 6.80s 6.89s
Emit Time 2.54s (± 0.84%) 2.64s (± 1.11%) +0.10s (+ 4.06%) 2.59s 2.73s
Total Time 10.65s (± 0.43%) 10.96s (± 0.31%) +0.31s (+ 2.87%) 10.91s 11.05s
Monaco - node (v12.1.0, x64)
Memory used 326,793k (± 0.05%) 327,498k (± 0.01%) +704k (+ 0.22%) 327,450k 327,580k
Parse Time 1.57s (± 0.64%) 1.70s (± 0.48%) +0.12s (+ 7.88%) 1.68s 1.71s
Bind Time 0.74s (± 1.10%) 0.75s (± 0.80%) +0.00s (+ 0.27%) 0.73s 0.76s
Check Time 5.83s (± 0.36%) 5.96s (± 0.39%) +0.13s (+ 2.26%) 5.92s 6.01s
Emit Time 3.30s (± 0.79%) 3.40s (± 0.63%) +0.10s (+ 3.00%) 3.36s 3.45s
Total Time 11.45s (± 0.32%) 11.81s (± 0.19%) +0.36s (+ 3.11%) 11.74s 11.85s
TFS - node (v12.1.0, x64)
Memory used 289,656k (± 0.06%) 290,190k (± 0.02%) +534k (+ 0.18%) 290,060k 290,276k
Parse Time 1.29s (± 0.50%) 1.40s (± 0.86%) +0.11s (+ 8.46%) 1.37s 1.42s
Bind Time 0.72s (± 1.24%) 0.72s (± 0.65%) +0.00s (+ 0.56%) 0.71s 0.73s
Check Time 5.36s (± 0.38%) 5.50s (± 0.52%) +0.14s (+ 2.69%) 5.44s 5.56s
Emit Time 3.51s (± 1.15%) 3.56s (± 1.26%) +0.04s (+ 1.19%) 3.44s 3.65s
Total Time 10.88s (± 0.49%) 11.18s (± 0.55%) +0.30s (+ 2.74%) 11.01s 11.29s
material-ui - node (v12.1.0, x64)
Memory used 448,368k (± 0.07%) 450,541k (± 0.01%) +2,173k (+ 0.48%) 450,453k 450,617k
Parse Time 1.82s (± 0.59%) 1.94s (± 0.57%) +0.12s (+ 6.37%) 1.92s 1.96s
Bind Time 0.67s (± 0.73%) 0.68s (± 1.07%) +0.00s (+ 0.59%) 0.66s 0.69s
Check Time 13.02s (± 0.54%) 13.17s (± 0.44%) +0.15s (+ 1.12%) 13.02s 13.28s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.52s (± 0.47%) 15.79s (± 0.42%) +0.27s (+ 1.73%) 15.63s 15.93s
xstate - node (v12.1.0, x64)
Memory used 543,462k (± 0.01%) 544,729k (± 0.02%) +1,267k (+ 0.23%) 544,552k 545,019k
Parse Time 2.54s (± 0.52%) 2.70s (± 0.39%) +0.16s (+ 6.22%) 2.68s 2.72s
Bind Time 1.02s (± 0.96%) 1.06s (± 0.87%) +0.04s (+ 3.91%) 1.04s 1.08s
Check Time 1.51s (± 0.74%) 1.58s (± 0.52%) +0.07s (+ 4.71%) 1.56s 1.60s
Emit Time 0.07s (± 0.00%) 0.07s (± 4.13%) +0.00s (+ 2.86%) 0.07s 0.08s
Total Time 5.14s (± 0.27%) 5.42s (± 0.21%) +0.28s (+ 5.45%) 5.40s 5.45s
Angular - node (v14.15.1, x64)
Memory used 335,938k (± 0.01%) 336,798k (± 0.01%) +861k (+ 0.26%) 336,745k 336,833k
Parse Time 2.06s (± 0.65%) 2.22s (± 0.82%) +0.16s (+ 7.70%) 2.19s 2.26s
Bind Time 0.90s (± 1.30%) 0.91s (± 0.73%) +0.01s (+ 1.22%) 0.90s 0.93s
Check Time 5.82s (± 0.41%) 5.99s (± 0.62%) +0.17s (+ 2.87%) 5.90s 6.06s
Emit Time 6.38s (± 0.63%) 6.59s (± 1.18%) +0.21s (+ 3.24%) 6.45s 6.76s
Total Time 15.17s (± 0.37%) 15.71s (± 0.72%) +0.54s (+ 3.57%) 15.46s 15.98s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,129k (± 0.01%) 193,566k (± 0.01%) +437k (+ 0.23%) 193,508k 193,596k
Parse Time 0.85s (± 0.68%) 0.95s (± 0.63%) +0.10s (+11.69%) 0.94s 0.96s
Bind Time 0.57s (± 1.01%) 0.58s (± 1.02%) +0.01s (+ 2.46%) 0.57s 0.60s
Check Time 6.71s (± 0.80%) 6.93s (± 0.64%) +0.22s (+ 3.26%) 6.83s 6.99s
Emit Time 2.49s (± 0.87%) 2.62s (± 0.81%) +0.13s (+ 5.39%) 2.56s 2.66s
Total Time 10.61s (± 0.54%) 11.08s (± 0.40%) +0.47s (+ 4.44%) 11.00s 11.19s
Monaco - node (v14.15.1, x64)
Memory used 325,664k (± 0.01%) 325,903k (± 0.01%) +239k (+ 0.07%) 325,863k 325,949k
Parse Time 1.58s (± 0.48%) 1.68s (± 0.48%) +0.10s (+ 6.54%) 1.66s 1.70s
Bind Time 0.78s (± 0.71%) 0.79s (± 0.86%) +0.01s (+ 1.53%) 0.78s 0.81s
Check Time 5.71s (± 0.46%) 5.85s (± 0.70%) +0.15s (+ 2.63%) 5.77s 5.94s
Emit Time 3.36s (± 0.58%) 3.46s (± 0.96%) +0.11s (+ 3.19%) 3.39s 3.57s
Total Time 11.42s (± 0.36%) 11.79s (± 0.59%) +0.37s (+ 3.25%) 11.63s 11.93s
TFS - node (v14.15.1, x64)
Memory used 288,822k (± 0.01%) 291,044k (± 0.01%) +2,222k (+ 0.77%) 290,998k 291,081k
Parse Time 1.33s (± 1.04%) 1.41s (± 1.17%) +0.08s (+ 6.25%) 1.38s 1.46s
Bind Time 0.77s (± 4.36%) 0.76s (± 0.88%) -0.01s (- 1.82%) 0.75s 0.78s
Check Time 5.36s (± 0.26%) 5.54s (± 0.42%) +0.18s (+ 3.42%) 5.50s 5.59s
Emit Time 3.54s (± 1.81%) 3.62s (± 1.54%) +0.08s (+ 2.35%) 3.44s 3.70s
Total Time 10.99s (± 0.57%) 11.33s (± 0.52%) +0.34s (+ 3.06%) 11.20s 11.44s
material-ui - node (v14.15.1, x64)
Memory used 446,711k (± 0.01%) 448,508k (± 0.00%) +1,796k (+ 0.40%) 448,462k 448,554k
Parse Time 1.88s (± 0.62%) 1.99s (± 0.41%) +0.11s (+ 5.64%) 1.97s 2.00s
Bind Time 0.72s (± 1.23%) 0.73s (± 1.29%) +0.01s (+ 1.10%) 0.71s 0.75s
Check Time 13.18s (± 0.51%) 13.41s (± 0.62%) +0.23s (+ 1.73%) 13.20s 13.52s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.78s (± 0.47%) 16.12s (± 0.51%) +0.34s (+ 2.16%) 15.92s 16.27s
xstate - node (v14.15.1, x64)
Memory used 541,295k (± 0.01%) 541,995k (± 0.00%) +700k (+ 0.13%) 541,943k 542,033k
Parse Time 2.60s (± 0.29%) 2.77s (± 0.29%) +0.17s (+ 6.54%) 2.75s 2.79s
Bind Time 1.15s (± 1.24%) 1.16s (± 0.70%) +0.01s (+ 1.04%) 1.14s 1.18s
Check Time 1.56s (± 0.49%) 1.61s (± 0.66%) +0.05s (+ 3.21%) 1.58s 1.63s
Emit Time 0.07s (± 4.66%) 0.08s (± 0.00%) +0.01s (+ 9.59%) 0.08s 0.08s
Total Time 5.38s (± 0.36%) 5.61s (± 0.29%) +0.24s (+ 4.37%) 5.57s 5.64s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50022 10
Baseline main 10

TSServer

Comparison Report - main..50022
Metric main 50022 Delta Best Worst
Compiler-UnionsTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,458ms (± 0.74%) 1,569ms (± 0.79%) +111ms (+ 7.58%) 1,551ms 1,603ms
Req 2 - geterr 3,622ms (± 0.89%) 3,732ms (± 0.65%) +110ms (+ 3.05%) 3,680ms 3,782ms
Req 3 - references 277ms (± 0.80%) 292ms (± 1.45%) +15ms (+ 5.45%) 283ms 304ms
Req 4 - navto 233ms (± 0.66%) 242ms (± 1.02%) +9ms (+ 3.64%) 238ms 249ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 69ms (±11.17%) 106ms (± 2.82%) 🔻+36ms (+52.38%) 99ms 112ms
CompilerTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,557ms (± 0.59%) 1,665ms (± 0.39%) +108ms (+ 6.94%) 1,646ms 1,677ms
Req 2 - geterr 2,275ms (± 0.37%) 2,379ms (± 0.50%) +104ms (+ 4.58%) 2,347ms 2,402ms
Req 3 - references 297ms (± 1.39%) 310ms (± 1.10%) +13ms (+ 4.38%) 302ms 318ms
Req 4 - navto 235ms (± 2.26%) 248ms (± 1.67%) +13ms (+ 5.58%) 232ms 252ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 69ms (± 1.48%) 76ms (± 5.31%) +7ms (+10.56%) 70ms 85ms
xstateTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 2,174ms (± 0.46%) 2,308ms (± 0.59%) +134ms (+ 6.16%) 2,282ms 2,337ms
Req 2 - geterr 773ms (± 0.66%) 815ms (± 0.97%) +41ms (+ 5.33%) 798ms 838ms
Req 3 - references 96ms (± 0.94%) 78ms (± 5.94%) 🟩-18ms (-18.64%) 74ms 96ms
Req 4 - navto 253ms (± 1.08%) 254ms (± 0.71%) +1ms (+ 0.47%) 250ms 257ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 271ms (± 1.16%) 282ms (± 0.81%) +12ms (+ 4.36%) 278ms 288ms
Compiler-UnionsTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,482ms (± 0.48%) 1,584ms (± 0.80%) +102ms (+ 6.86%) 1,559ms 1,622ms
Req 2 - geterr 3,400ms (± 0.65%) 3,498ms (± 0.44%) +98ms (+ 2.88%) 3,470ms 3,531ms
Req 3 - references 263ms (± 0.59%) 270ms (± 1.81%) +7ms (+ 2.66%) 263ms 282ms
Req 4 - navto 203ms (± 0.69%) 208ms (± 1.41%) +6ms (+ 2.71%) 199ms 215ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 88ms (±12.11%) 100ms (± 5.17%) +12ms (+14.03%) 95ms 120ms
CompilerTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,563ms (± 0.55%) 1,653ms (± 0.58%) +90ms (+ 5.78%) 1,630ms 1,672ms
Req 2 - geterr 2,218ms (± 0.54%) 2,304ms (± 0.77%) +86ms (+ 3.88%) 2,254ms 2,334ms
Req 3 - references 274ms (± 0.74%) 283ms (± 1.03%) +9ms (+ 3.25%) 275ms 288ms
Req 4 - navto 213ms (± 0.81%) 220ms (± 2.40%) +7ms (+ 3.05%) 211ms 238ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 63ms (± 3.12%) 71ms (± 6.03%) +8ms (+13.33%) 63ms 80ms
xstateTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 2,100ms (± 0.65%) 2,210ms (± 0.97%) +109ms (+ 5.20%) 2,177ms 2,268ms
Req 2 - geterr 763ms (± 0.55%) 787ms (± 0.66%) +24ms (+ 3.09%) 771ms 796ms
Req 3 - references 67ms (± 2.04%) 75ms (± 1.11%) +8ms (+11.34%) 72ms 76ms
Req 4 - navto 239ms (± 1.21%) 238ms (± 1.34%) -2ms (- 0.75%) 229ms 243ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 261ms (± 0.76%) 281ms (± 0.48%) +20ms (+ 7.78%) 279ms 284ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,523ms (± 0.48%) 1,635ms (± 0.41%) +112ms (+ 7.35%) 1,617ms 1,648ms
Req 2 - geterr 3,532ms (± 0.66%) 3,654ms (± 0.57%) +122ms (+ 3.44%) 3,617ms 3,698ms
Req 3 - references 278ms (± 0.81%) 285ms (± 1.41%) +7ms (+ 2.52%) 274ms 295ms
Req 4 - navto 218ms (± 0.58%) 225ms (± 0.64%) +7ms (+ 3.07%) 222ms 229ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 60ms (± 6.59%) 62ms (± 1.87%) +1ms (+ 2.32%) 60ms 66ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,606ms (± 0.73%) 1,727ms (± 0.42%) +121ms (+ 7.56%) 1,714ms 1,747ms
Req 2 - geterr 2,356ms (± 0.32%) 2,430ms (± 0.59%) +74ms (+ 3.16%) 2,395ms 2,450ms
Req 3 - references 289ms (± 1.03%) 293ms (± 0.47%) +5ms (+ 1.56%) 291ms 296ms
Req 4 - navto 232ms (± 1.44%) 247ms (± 1.74%) +16ms (+ 6.74%) 236ms 254ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 53ms (± 0.98%) 62ms (± 1.25%) +9ms (+16.57%) 60ms 64ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,216ms (± 0.45%) 2,336ms (± 0.57%) +120ms (+ 5.42%) 2,296ms 2,370ms
Req 2 - geterr 773ms (± 0.53%) 805ms (± 0.61%) +32ms (+ 4.17%) 796ms 817ms
Req 3 - references 65ms (± 1.78%) 72ms (± 1.22%) +7ms (+11.28%) 71ms 74ms
Req 4 - navto 250ms (± 0.77%) 251ms (± 0.98%) +1ms (+ 0.24%) 245ms 256ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 265ms (± 0.63%) 281ms (± 0.78%) +16ms (+ 6.20%) 277ms 286ms
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v10.16.3, x64)
  • Compiler-UnionsTSServer - node (v12.1.0, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v10.16.3, x64)
  • CompilerTSServer - node (v12.1.0, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50022 10
Baseline main 10

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

nooooo

@jakebailey
Copy link
Member Author

Wish we had node 16 and 18 to test...

@jakebailey
Copy link
Member Author

And that we had an esbuild-like thing to say "emit all new stuff but... downlevel to var anyway"

@Andarist
Copy link
Contributor

@jakebailey out of curiosity - why let/const are the likely culprits here? Does TDZ come with such a cost? or perhaps just a matter of block scoping having such an overhead (there are more scopes created/maintained)?

@jakebailey
Copy link
Member Author

I'm guessing this is TDZ, yeah, I just haven't actually gone to compare traces to see if there's any obvious culprits.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jul 26, 2022 •
edited

I would guess that two culprits are

  • TDZ
  • Native iteration and generators

This was referenced Aug 2, 2022
Closed
Merged
@jakebailey jakebailey mentioned this pull request Sep 19, 2022
Closed
5 tasks
@jakebailey
Copy link
Member Author

The code that I used to fix the crashes has been merged in #50151; I'm going to close this since it seems like we're not going to change our emit target any time soon as the performance hit of let/const is just too great.

See also #49332 (comment).

@jakebailey jakebailey closed this Sep 19, 2022
@jakebailey jakebailey deleted the update-target branch October 20, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakebailey @typescript-bot @Andarist @DanielRosenwasser