Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve check of whether type query node possibly contains reference to type parameter #50070
Improve check of whether type query node possibly contains reference to type parameter #50070
Changes from 9 commits
4a6a005
b501b47
6d2c0f9
028b30c
b17a5dd
5853796
03bc5fe
f05889e
4269875
fbf3cad
8fa0061
6edce8c
8ff3987
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the
some
function instead offorEach
. Also, to get the declaration oftp
usegetDeclarationOfKind<TypeParameterDeclaration>(tp.symbol, SyntaxKind.TypeParameter)!
. Although very unlikely, it is possible for there to be other declarations in the array, for example if the same name is used for a type parameter and a regular parameter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't come up with a test program such that type checking it observed the consequences of an incorrect
containsReference
/typeParameterIsPossiblyReferenced
result in the presence of type parameter aliasing, so I wrote a unit test for it.