Make the importServicePlugin internal #50572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
rbuckton,
mjbvz,
andrewbranch and
DanielRosenwasser
and removed request for
rbuckton and
mjbvz
|
If we are not taking #50554 we should definitely take this for 4.8 so we have some wiggle room to name API for figuring out custom watch plugin story from tsc as well as editor |
|
@typescript-bot cherry-pick this to release-4.8 |
|
Heya @sheetalkamat, I've started to run the task to cherry-pick this into |
|
Hey @sheetalkamat, I've opened #50573 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 31, 2022
Component commits: 5e96e58 Lets make the importServicePlugin internal for now?
|
Closing this as we agreed to take both changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.