Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'async' dependency, used only in errorCheck.ts, modernize file #50667

Merged
merged 2 commits into from Sep 23, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 0 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Expand Up @@ -40,7 +40,6 @@
],
"devDependencies": {
"@octokit/rest": "latest",
"@types/async": "latest",
"@types/chai": "latest",
"@types/fs-extra": "^9.0.13",
"@types/glob": "latest",
Expand All @@ -62,7 +61,6 @@
"@typescript-eslint/eslint-plugin": "^5.33.1",
"@typescript-eslint/parser": "^5.33.1",
"@typescript-eslint/utils": "^5.33.1",
"async": "latest",
"azure-devops-node-api": "^11.2.0",
"chai": "latest",
"chalk": "^4.1.2",
Expand Down
27 changes: 11 additions & 16 deletions scripts/errorCheck.ts
@@ -1,5 +1,4 @@
import * as fs from "fs";
import * as async from "async";
import * as glob from "glob";

fs.readFile("src/compiler/diagnosticMessages.json", "utf-8", (err, data) => {
Expand All @@ -20,8 +19,8 @@ fs.readFile("src/compiler/diagnosticMessages.json", "utf-8", (err, data) => {

fs.readdir(baseDir, (err, files) => {
files = files.filter(f => f.indexOf(".errors.txt") > 0);
const tasks: ((callback: () => void) => void)[] = [];
files.forEach(f => tasks.push(done => {

files.forEach(f => {
fs.readFile(baseDir + f, "utf-8", (err, baseline) => {
if (err) throw err;

Expand All @@ -31,22 +30,18 @@ fs.readFile("src/compiler/diagnosticMessages.json", "utf-8", (err, data) => {
const msg = keys.filter(k => messages[k].code === errCode)[0];
messages[msg].seen = true;
}

done();
});
}));
});

async.parallelLimit(tasks, 25, done => {
jakebailey marked this conversation as resolved.
Show resolved Hide resolved
console.log("== List of errors not present in baselines ==");
let count = 0;
for (const k of keys) {
if (messages[k].seen !== true) {
console.log(k);
count++;
}
console.log("== List of errors not present in baselines ==");
jakebailey marked this conversation as resolved.
Show resolved Hide resolved
let count = 0;
for (const k of keys) {
if (messages[k].seen !== true) {
console.log(k);
count++;
}
console.log(count + " of " + keys.length + " errors are not in baselines");
});
}
console.log(count + " of " + keys.length + " errors are not in baselines");
});
});

Expand Down