Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve escape sequence handling in private names #50856

Merged
merged 7 commits into from Sep 20, 2022
Merged

Improve escape sequence handling in private names #50856

merged 7 commits into from Sep 20, 2022

Commits on Sep 20, 2022

  1. Add tests for identifiers and private identifiers with escape sequences.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2022
    Copy the full SHA
    77d7109 View commit details
    Browse the repository at this point in the history

  2. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2022
    Copy the full SHA
    3f8b934 View commit details
    Browse the repository at this point in the history

  3. Store the tokenValue instead of tokenText on PrivateIdentifiers, sinc… 

    …e the latter can contain escapes and lead to semantic discrepancies.
    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2022
    Copy the full SHA
    69195a9 View commit details
    Browse the repository at this point in the history

  4. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2022
    Copy the full SHA
    fec0977 View commit details
    Browse the repository at this point in the history

  5. Check for leading escape sequences in PrivateIdentifiers.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2022
    Copy the full SHA
    6fccba5 View commit details
    Browse the repository at this point in the history

  6. Accepted baselines.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2022
    Copy the full SHA
    83b3ea3 View commit details
    Browse the repository at this point in the history

  7. Fix lints.

    @DanielRosenwasser
    DanielRosenwasser committed Sep 20, 2022
    Copy the full SHA
    82d0fc9 View commit details
    Browse the repository at this point in the history