Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in goto-def on @override #51016

Merged
merged 8 commits into from Oct 3, 2022
Merged

Fix crash in goto-def on @override #51016

merged 8 commits into from Oct 3, 2022

Commits on Sep 30, 2022

  1. Fix crash in goto-def on @override 

    When the base type is not defined, getDefinitionFromOverriddenMember
will have its type as errorType, which has no symbol. The error handling
previously only handled the case of no baseType at all -- which I'm not
sure ever actually happens.
    @sandersn
    sandersn committed Sep 30, 2022
    Copy the full SHA
    2710ea8 View commit details
    Browse the repository at this point in the history

  2. Improve checking 

    1. getTypeAtLocation never returns undefined, only errorType, so check for that.
2. Return directly after missing baseTypeNode instead of continuing to return later.
    @sandersn
    sandersn committed Sep 30, 2022
    Copy the full SHA
    0487e3b View commit details
    Browse the repository at this point in the history

  3. Experiment with making goto-def on override more consistent

    @sandersn
    sandersn committed Sep 30, 2022
    Copy the full SHA
    13c7008 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Unify static/instance node->symbol->type path

    @sandersn
    sandersn committed Oct 1, 2022
    Copy the full SHA
    6ef2904 View commit details
    Browse the repository at this point in the history

  2. Make getSymbolAtLocation support class expressions 

    and parenthesized expressions
    @sandersn
    sandersn committed Oct 1, 2022
    Copy the full SHA
    4c1b031 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Revert "Make getSymbolAtLocation support class expressions" 

    This reverts commit 4c1b031.
    @sandersn
    sandersn committed Oct 3, 2022
    Copy the full SHA
    92415cd View commit details
    Browse the repository at this point in the history

  2. fix semicolon lint

    @sandersn
    sandersn committed Oct 3, 2022
    Copy the full SHA
    c1babc8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-crash-in-goto-def-override

    @sandersn
    sandersn committed Oct 3, 2022
    Copy the full SHA
    2a645a3 View commit details
    Browse the repository at this point in the history