Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typescript.d.ts in APISample tests #51061

Merged
merged 2 commits into from Oct 4, 2022
Merged

Use typescript.d.ts in APISample tests #51061

merged 2 commits into from Oct 4, 2022

Commits on Oct 4, 2022

  1. Fix APISample tests to not depend on the existence of the ts namespace 

    The way we pull in the types for typescript in these tests only works
when we include typescriptServices.d.ts into the project, which declares
a global namespace, which then is reexported as the typescript package.

This reexport is already what the current typescript.d.ts does, but now
that we don't have the namespace at all, we can't do this. Instead,
simulate the typescript package directly and point it at the correct
d.ts file.

This is a good chagne regardless of the module transform, and could be
cherry-picked back to main early.
    @jakebailey
    jakebailey committed Oct 4, 2022
    Copy the full SHA
    a80cdfb View commit details
    Browse the repository at this point in the history

  2. Remove unused constant

    @jakebailey
    jakebailey committed Oct 4, 2022
    Copy the full SHA
    d06719f View commit details
    Browse the repository at this point in the history