Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(51100): ensure tsserver shuts down when parent process is killed #51107

Merged
merged 2 commits into from Oct 10, 2022

Commits on Oct 8, 2022

  1. fix(51100): ensure tsserver shuts down when parent process is killed

    When using IPC channel (`--useNodeIpc`) for communicating with tsserver,
    the child tsserver process did not shut down on parent process disconnecting
    (for example due to it being killed).
    
    Call exit() on IPC disconnect, same as stdio-based communication did
    when pipe to parent process was destroyed.
    rchl committed Oct 8, 2022
    Copy the full SHA
    9b325ac View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. don't duplicate inherited method

    rchl committed Oct 10, 2022
    Copy the full SHA
    91117f6 View commit details
    Browse the repository at this point in the history