-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to var in binder for top level variables #52903
Conversation
@typescript-bot perf test this |
Heya @jakebailey, I've started to run the perf test suite on this PR at e7c5b69. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - main..52903
System
Hosts
Scenarios
TSServerComparison Report - main..52903
System
Hosts
Scenarios
StartupComparison Report - main..52903
System
Hosts
Scenarios
Developer Information: |
wowee |
var unreachableFlow: FlowNode = { flags: FlowFlags.Unreachable }; | ||
var reportedUnreachableFlow: FlowNode = { flags: FlowFlags.Unreachable }; | ||
var bindBinaryExpressionFlow = createBindBinaryExpressionFlow(); | ||
/* eslint-enable no-var */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So one thing I was thinking with these - we should really move the return
statement immediately closer to these so that it is clear that this is where shared state resides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a good idea; I think the checker already does this. Let me do that and rerun perf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JK, it's right there, two functions down.
Followup to #52832 and others.