Run lint in parallel with runtests-parallel #52945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
approved these changes
Feb 24, 2023
|
I've added a test to hereby that should encode that this trick still works. |
DanielRosenwasser
approved these changes
Feb 24, 2023
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
|
I've modified this to only do it at parallel; @andrewbranch pointed out that we probably don't want to lint on filtered tests, which I think most people only run in But, I can also make it not lint if the tests are filtered, if that sounds good too. |
sandersn
approved these changes
Feb 24, 2023
jakebailey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively reverts #50597, except that instead of running the linter after tests have finished, we'll instead run them in parallel. This works because hereby won't exit early when a task fails but a sibling task has not yet finished.
I still prefer getting these in my editor where possible, but, I've heard from multiple people ambiently that they keep committing code that fails the lint task. At least we can do it in parallel in the new build.