Fix self-name input linking for --allowJs --declaration projects #54819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
jakebailey
reviewed
Jun 28, 2023
sheetalkamat
requested changes
Jun 28, 2023
| // to ensure that self-name imports of their own package can resolve back to their | ||
| // input JS files via `tryLoadInputFileForPath` at a higher priority than their output | ||
| // declaration files, so we need to do a single pass with all extensions for that case. | ||
| if (getAllowJSCompilerOption(state.compilerOptions) && !pathContainsNodeModules(directory)) { |
There was a problem hiding this comment.
I think with this we need to add affectsModuleResolution to "checkJs" in commandline options declaration.
There was a problem hiding this comment.
Ooh, yikes. I can do that for now, but maybe it would be better to update getCompilerOptionValue (called by optionsHaveChanges functions) to use all the computed compiler option getter functions sometime in the future.
There was a problem hiding this comment.
checkJs doesn’t even have affectsSemanticDiagnostics. Does it need it?
There was a problem hiding this comment.
it does. #53403 never made it in i guess.
There was a problem hiding this comment.
I’ll leave it off of this one and then we should revisit #53403
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
sheetalkamat
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54299
Related: #52185