String#matchAll should return iterable of RegExpExecArray (fixes #36788) #55565

nihil-admirari · 2023-08-29T19:43:25Z

matchAll accepts only global RegExps and thus, if it didn't throw, it always returns RegExpExecArray with non-optional index and input.

Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/matchAll#return_value.

nihil-admirari · 2023-08-29T20:27:31Z

@microsoft-github-policy-service agree

jakebailey · 2023-08-29T21:45:59Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-08-29T21:46:04Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at d0be0cd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-29T21:46:04Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at d0be0cd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-29T21:46:04Z

Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at d0be0cd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-29T21:46:04Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at d0be0cd. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-29T22:04:25Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55565/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55565/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-08-29T22:20:38Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,268k (± 0.00%)}	_{300,284k (± 0.01%)}	_~	_300,256k	_300,302k	_{p=0.230 n=6}
_{Parse Time}	_{3.01s (± 0.18%)}	_{3.00s (± 0.34%)}	_~	_2.99s	_3.02s	_{p=0.663 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=0.405 n=6}
_{Check Time}	_{9.30s (± 0.24%)}	_{9.32s (± 0.43%)}	_~	_9.27s	_9.38s	_{p=0.627 n=6}
_{Emit Time}	_{7.62s (± 0.33%)}	_{7.64s (± 0.39%)}	_~	_7.60s	_7.68s	_{p=0.332 n=6}
_{Total Time}	_{20.86s (± 0.21%)}	_{20.89s (± 0.28%)}	_~	_20.80s	_20.95s	_{p=0.335 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,960k (± 0.01%)}	_{194,434k (± 0.68%)}	_~	_193,870k	_197,124k	_{p=0.173 n=6}
_{Parse Time}	_{1.58s (± 0.00%)}	_{1.58s (± 0.00%)}	_~	_1.58s	_1.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.80s (± 0.65%)}	_{0.80s (± 0.65%)}	_~	_0.79s	_0.80s	_{p=1.000 n=6}
_{Check Time}	_{9.96s (± 0.43%)}	_{9.92s (± 0.36%)}	_~	_9.87s	_9.96s	_{p=0.169 n=6}
_{Emit Time}	_{2.74s (± 0.15%)}	_{2.73s (± 0.20%)}	_~	_2.73s	_2.74s	_{p=0.282 n=6}
_{Total Time}	_{15.07s (± 0.29%)}	_{15.03s (± 0.23%)}	_~	_14.98s	_15.07s	_{p=0.108 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,195k (± 0.00%)}	_{347,172k (± 0.01%)}	_~	_347,103k	_347,193k	_{p=0.336 n=6}
_{Parse Time}	_{2.69s (± 0.30%)}	_{2.69s (± 0.43%)}	_~	_2.68s	_2.71s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.96s (± 1.16%)}	_{7.93s (± 0.33%)}	_~	_7.89s	_7.96s	_{p=0.936 n=6}
_{Emit Time}	_{4.27s (± 0.37%)}	_{4.27s (± 0.45%)}	_~	_4.24s	_4.29s	_{p=1.000 n=6}
_{Total Time}	_{15.91s (± 0.68%)}	_{15.87s (± 0.23%)}	_~	_15.83s	_15.92s	_{p=0.872 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,167k (± 0.01%)}	_{301,180k (± 0.00%)}	_~	_301,169k	_301,186k	_{p=0.173 n=6}
_{Parse Time}	_{2.17s (± 0.50%)}	_{2.18s (± 0.73%)}	_~	_2.15s	_2.20s	_{p=0.322 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.09s (± 5.72%)}	_~	_0.96s	_1.12s	_{p=0.386 n=6}
_{Check Time}	_{7.24s (± 0.29%)}	_{7.21s (± 0.34%)}	_~	_7.17s	_7.24s	_{p=0.107 n=6}
_{Emit Time}	_{3.98s (± 0.42%)}	_{3.98s (± 0.27%)}	_~	_3.97s	_4.00s	_{p=1.000 n=6}
_{Total Time}	_{14.51s (± 0.19%)}	_{14.46s (± 0.62%)}	_~	_14.29s	_14.55s	_{p=0.224 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,475k (± 0.00%)}	_{479,471k (± 0.00%)}	_~	_479,448k	_479,494k	_{p=0.689 n=6}
_{Parse Time}	_{3.15s (± 0.24%)}	_{3.15s (± 0.24%)}	_~	_3.14s	_3.16s	_{p=1.000 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.81s (± 0.53%)}	_{17.80s (± 0.41%)}	_~	_17.68s	_17.88s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.87s (± 0.44%)}	_{21.86s (± 0.35%)}	_~	_21.73s	_21.94s	_{p=0.872 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,895k (± 0.02%)}	_{542,802k (± 0.01%)}	_~	_542,704k	_542,851k	_{p=0.066 n=6}
_{Parse Time}	_{3.70s (± 0.17%)}	_{3.69s (± 0.40%)}	_~	_3.67s	_3.71s	_{p=0.156 n=6}
_{Bind Time}	_{1.42s (± 4.20%)}	_{1.46s (± 0.38%)}	_~	_1.45s	_1.46s	_{p=0.341 n=6}
_{Check Time}	_{3.22s (± 2.84%)}	_{3.16s (± 0.89%)}	_~	_3.13s	_3.20s	_{p=0.293 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.42s (± 0.46%)}	_{8.38s (± 0.38%)}	_~	_8.35s	_8.44s	_{p=0.050 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-08-29T22:47:22Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55565/merge:

Everything looks good!

typescript-bot · 2023-08-30T00:01:05Z

Hey @jakebailey, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: string.prototype.matchall
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/string.prototype.matchall/string.prototype.matchall-tests.ts:11:1
ERROR: 11:1  expect  TypeScript@local expected type to be:
  IterableIterator<RegExpMatchArray>
got:
  IterableIterator<RegExpExecArray>
ERROR: 12:1  expect  TypeScript@local expected type to be:
  IterableIterator<RegExpMatchArray>
got:
  IterableIterator<RegExpExecArray>

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

nihil-admirari · 2023-08-30T21:13:35Z

@jakebailey, sorry, I'm new here. Where string.prototype.matchall-tests.ts is located?

jakebailey · 2023-08-30T21:32:08Z

That's over in https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/string.prototype.matchall

This is somewhat an expected failure because that other package duplicated the type, so is going to need typesVersions to fix.

nihil-admirari · 2023-09-02T10:05:00Z

I've made a pull request to DefinitelyTyped but it's failing the tests and it'll continue to fail unless this pull request is merged.

DanielRosenwasser · 2023-10-04T20:44:41Z

I think we can take this in post-beta. Thoughts @sandersn?

sandersn · 2023-10-09T22:06:24Z

It seems quite safe for a change to the stdlib, since it's only in es2020 and above.
I'm OK with merging it if you're OK with shipping a point release to revert it if needed!

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 29, 2023

String#matchAll should return iterable of RegExpExecArray (fixes #36788)

d0be0cd

jakebailey mentioned this pull request Aug 29, 2023

Sanitize ts repo root in errors microsoft/typescript-error-deltas#126

Merged

nihil-admirari mentioned this pull request Sep 1, 2023

String#matchAll should return iterable of RegExpExecArray (fixes TypeScript#36788) DefinitelyTyped/DefinitelyTyped#66581

Closed

8 tasks

sandersn added this to Not started in PR Backlog Sep 6, 2023

sandersn assigned navya9singh Sep 7, 2023

sandersn requested review from sandersn and navya9singh September 7, 2023 22:06

sandersn moved this from Not started to Waiting on reviewers in PR Backlog Sep 7, 2023

DanielRosenwasser approved these changes Oct 4, 2023

View reviewed changes

PR Backlog automation moved this from Waiting on reviewers to Needs merge Oct 4, 2023

sandersn approved these changes Nov 30, 2023

View reviewed changes

Merge branch 'main' into main

80bdbe5

sandersn merged commit fd74874 into microsoft:main Nov 30, 2023
19 checks passed

PR Backlog automation moved this from Needs merge to Done Nov 30, 2023

sandersn mentioned this pull request Dec 4, 2023

Update string.prototype.matchall for TS 5.4 DefinitelyTyped/DefinitelyTyped#67760

Merged

fatcerberus mentioned this pull request Jan 11, 2024

Inaccurate Type Definition for String.prototype.matchAll #57024

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

String#matchAll should return iterable of RegExpExecArray (fixes #36788) #55565

String#matchAll should return iterable of RegExpExecArray (fixes #36788) #55565

nihil-admirari commented Aug 29, 2023

nihil-admirari commented Aug 29, 2023

jakebailey commented Aug 29, 2023

typescript-bot commented Aug 29, 2023 •

edited

typescript-bot commented Aug 29, 2023 •

edited

typescript-bot commented Aug 29, 2023 •

edited

typescript-bot commented Aug 29, 2023 •

edited

typescript-bot commented Aug 29, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Aug 29, 2023

Compiler

typescript-bot commented Aug 29, 2023

typescript-bot commented Aug 30, 2023

nihil-admirari commented Aug 30, 2023

jakebailey commented Aug 30, 2023

nihil-admirari commented Sep 2, 2023

DanielRosenwasser commented Oct 4, 2023

sandersn commented Oct 9, 2023

String#matchAll should return iterable of RegExpExecArray (fixes #36788) #55565

String#matchAll should return iterable of RegExpExecArray (fixes #36788) #55565

Conversation

nihil-admirari commented Aug 29, 2023

nihil-admirari commented Aug 29, 2023

jakebailey commented Aug 29, 2023

typescript-bot commented Aug 29, 2023 • edited

typescript-bot commented Aug 29, 2023 • edited

typescript-bot commented Aug 29, 2023 • edited

typescript-bot commented Aug 29, 2023 • edited

typescript-bot commented Aug 29, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Aug 29, 2023

Compiler

typescript-bot commented Aug 29, 2023

typescript-bot commented Aug 30, 2023

nihil-admirari commented Aug 30, 2023

jakebailey commented Aug 30, 2023

nihil-admirari commented Sep 2, 2023

DanielRosenwasser commented Oct 4, 2023

sandersn commented Oct 9, 2023

typescript-bot commented Aug 29, 2023 •

edited

typescript-bot commented Aug 29, 2023 •

edited

typescript-bot commented Aug 29, 2023 •

edited

typescript-bot commented Aug 29, 2023 •

edited