Error on excessive relation complexity #55851

ahejlsberg · 2023-09-25T01:57:35Z

With this PR we now error when computing a relation is excessively complex. Specifically, when computing a relation results in adding more relation cache entries than 1/8th of the current capacity of that relation, we issue an error. Relation caches use JavaScript maps, which in Node.js are limited to 2^24 (~16M) entries.

An example of a relation computation that is excessively complex is the following:

type Digits = '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9';
type T1 = `${Digits}${Digits}${Digits}${Digits}` | undefined;
type T2 = { a: string } | { b: number };

function f1(x: T1 | null, y: T1 & T2) {
    x = y;  // Excessive complexity error
}

Above, T1 is a union with 10,001 members, and T2 normalizes to a union with 20,002 members.

This PR further implements an optimization outlined here. For example, the following example doesn't cause an excessive complexity error because we now have a fast path when relating a union resulting from normalizing an intersection of large unions to one of those same unions.

function f2(x: T1, y: T1 & T2) {
    x = y;  // Ok
}

Fixes #55630.

# Conflicts: # src/compiler/diagnosticMessages.json

ahejlsberg · 2023-09-25T14:04:23Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-09-25T14:04:26Z

Heya @ahejlsberg, I've started to run the tsc-only perf test suite on this PR at 89f5d10. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T14:04:26Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 89f5d10. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T14:04:26Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 89f5d10. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T14:04:26Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 89f5d10. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-25T14:18:27Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,958k (± 0.01%)}	_{294,960k (± 0.01%)}	_~	_294,938k	_294,997k	_{p=1.000 n=6}
_{Parse Time}	_{2.62s (± 0.31%)}	_{2.63s (± 0.47%)}	_~	_2.61s	_2.64s	_{p=0.730 n=6}
_{Bind Time}	_{0.84s (± 1.17%)}	_{0.84s (± 0.97%)}	_~	_0.83s	_0.85s	_{p=0.394 n=6}
_{Check Time}	_{8.05s (± 0.46%)}	_{8.06s (± 0.34%)}	_~	_8.03s	_8.10s	_{p=0.629 n=6}
_{Emit Time}	_{7.05s (± 0.30%)}	_{7.03s (± 0.16%)}	_~	_7.01s	_7.04s	_{p=0.061 n=6}
_{Total Time}	_{18.56s (± 0.22%)}	_{18.55s (± 0.16%)}	_~	_18.50s	_18.58s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,115k (± 1.24%)}	_{193,628k (± 1.64%)}	_~	_190,726k	_196,592k	_{p=0.423 n=6}
_{Parse Time}	_{1.34s (± 0.77%)}	_{1.34s (± 1.05%)}	_~	_1.32s	_1.36s	_{p=0.738 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.11s (± 0.54%)}	_{9.17s (± 0.46%)}	_~	_9.12s	_9.24s	_{p=0.078 n=6}
_{Emit Time}	_{2.64s (± 0.44%)}	_{2.63s (± 0.83%)}	_~	_2.60s	_2.66s	_{p=0.192 n=6}
_{Total Time}	_{13.81s (± 0.45%)}	_{13.87s (± 0.30%)}	_~	_13.79s	_13.91s	_{p=0.092 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,217k (± 0.00%)}	_{347,209k (± 0.01%)}	_~	_347,183k	_347,239k	_{p=0.575 n=6}
_{Parse Time}	_{2.46s (± 0.43%)}	_{2.44s (± 0.34%)}	_~	_2.44s	_2.46s	_{p=0.109 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{6.88s (± 0.41%)}	_{6.88s (± 0.58%)}	_~	_6.84s	_6.94s	_{p=1.000 n=6}
_{Emit Time}	_{4.02s (± 0.41%)}	_{4.02s (± 0.34%)}	_~	_4.01s	_4.05s	_{p=0.505 n=6}
_{Total Time}	_{14.28s (± 0.28%)}	_{14.29s (± 0.19%)}	_~	_14.26s	_14.33s	_{p=0.808 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,484k (± 0.00%)}	_{302,554k (± 0.01%)}	_{+71k (+ 0.02%)}	_302,498k	_302,598k	_{p=0.008 n=6}
_{Parse Time}	_{2.01s (± 0.41%)}	_{2.00s (± 0.63%)}	_{-0.01s (- 0.74%)}	_1.98s	_2.01s	_{p=0.038 n=6}
_{Bind Time}	_{1.00s (± 1.17%)}	_{1.00s (± 0.83%)}	_~	_0.99s	_1.01s	_{p=0.555 n=6}
_{Check Time}	_{6.25s (± 0.28%)}	_{6.25s (± 0.48%)}	_~	_6.22s	_6.30s	_{p=0.870 n=6}
_{Emit Time}	_{3.54s (± 1.34%)}	_{3.53s (± 0.83%)}	_~	_3.50s	_3.57s	_{p=1.000 n=6}
_{Total Time}	_{12.81s (± 0.38%)}	_{12.80s (± 0.32%)}	_~	_12.74s	_12.86s	_{p=0.630 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,448k (± 0.00%)}	_{470,426k (± 0.01%)}	_~	_470,382k	_470,463k	_{p=0.128 n=6}
_{Parse Time}	_{2.57s (± 0.58%)}	_{2.56s (± 0.64%)}	_~	_2.55s	_2.59s	_{p=0.314 n=6}
_{Bind Time}	_{1.00s (± 0.75%)}	_{0.99s (± 1.04%)}	_~	_0.98s	_1.01s	_{p=0.155 n=6}
_{Check Time}	_{16.56s (± 0.59%)}	_{16.57s (± 0.33%)}	_~	_16.51s	_16.67s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.13s (± 0.56%)}	_{20.13s (± 0.24%)}	_~	_20.08s	_20.21s	_{p=0.748 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,548k (± 0.01%)}	_{512,514k (± 0.02%)}	_~	_512,399k	_512,749k	_{p=0.298 n=6}
_{Parse Time}	_{3.27s (± 0.17%)}	_{3.27s (± 0.23%)}	_~	_3.26s	_3.28s	_{p=0.476 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.55s (± 0.53%)}	_~	_1.54s	_1.56s	_{p=0.929 n=6}
_{Check Time}	_{2.83s (± 0.69%)}	_{2.85s (± 1.15%)}	_~	_2.80s	_2.90s	_{p=0.226 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.71s (± 0.25%)}	_{7.74s (± 0.43%)}	_~	_7.69s	_7.79s	_{p=0.196 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-25T14:24:57Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/55851/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-25T15:05:47Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/55851/merge:

Everything looks good!

typescript-bot · 2023-09-25T15:26:54Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

gabritto · 2023-09-25T19:04:42Z

On PR #50329, @weswigham had proposed a more general form of the optimization found on this PR. What's the reasoning behind picking this simpler form of the optimization instead?

ahejlsberg · 2023-09-25T19:14:26Z

What's the reasoning behind picking this simpler form of the optimization instead?

I hadn't seen #50329, but certainly the optimization in this PR removes far more work when the fast path is available. There's no reason the two couldn't co-exist.

# Conflicts: # src/compiler/diagnosticMessages.json

ahejlsberg · 2023-09-26T21:59:29Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-09-26T21:59:32Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at be68f32. You can monitor the build here.

typescript-bot · 2023-09-26T21:59:32Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at be68f32. You can monitor the build here.

typescript-bot · 2023-09-26T21:59:32Z

Heya @ahejlsberg, I've started to run the tsc-only perf test suite on this PR at be68f32. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-26T21:59:32Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at be68f32. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-26T22:12:08Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,994k (± 0.01%)}	_{294,988k (± 0.01%)}	_~	_294,945k	_295,050k	_{p=0.873 n=6}
_{Parse Time}	_{2.64s (± 0.73%)}	_{2.63s (± 0.65%)}	_~	_2.60s	_2.65s	_{p=0.216 n=6}
_{Bind Time}	_{0.84s (± 0.97%)}	_{0.84s (± 1.17%)}	_~	_0.83s	_0.85s	_{p=0.394 n=6}
_{Check Time}	_{8.06s (± 0.21%)}	_{8.06s (± 0.35%)}	_~	_8.02s	_8.09s	_{p=0.935 n=6}
_{Emit Time}	_{7.04s (± 0.15%)}	_{7.04s (± 0.25%)}	_~	_7.02s	_7.07s	_{p=1.000 n=6}
_{Total Time}	_{18.58s (± 0.13%)}	_{18.57s (± 0.24%)}	_~	_18.52s	_18.65s	_{p=0.517 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{190,707k (± 0.01%)}	_{192,093k (± 1.25%)}	_~	_190,656k	_196,506k	_{p=1.000 n=6}
_{Parse Time}	_{1.35s (± 0.56%)}	_{1.35s (± 0.47%)}	_~	_1.34s	_1.36s	_{p=0.718 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.15s (± 0.63%)}	_{9.16s (± 0.31%)}	_~	_9.12s	_9.20s	_{p=0.468 n=6}
_{Emit Time}	_{2.63s (± 0.50%)}	_{2.64s (± 0.59%)}	_~	_2.62s	_2.66s	_{p=0.452 n=6}
_{Total Time}	_{13.86s (± 0.32%)}	_{13.88s (± 0.22%)}	_~	_13.84s	_13.93s	_{p=0.370 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,227k (± 0.01%)}	_{347,240k (± 0.00%)}	_~	_347,213k	_347,257k	_{p=0.378 n=6}
_{Parse Time}	_{2.46s (± 0.56%)}	_{2.45s (± 0.26%)}	_~	_2.44s	_2.46s	_{p=0.362 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.94s (± 0.88%)}	_~	_0.94s	_0.96s	_{p=0.527 n=6}
_{Check Time}	_{6.87s (± 0.28%)}	_{6.88s (± 0.20%)}	_~	_6.86s	_6.90s	_{p=0.167 n=6}
_{Emit Time}	_{4.03s (± 0.43%)}	_{4.03s (± 0.29%)}	_~	_4.02s	_4.05s	_{p=1.000 n=6}
_{Total Time}	_{14.29s (± 0.27%)}	_{14.31s (± 0.17%)}	_~	_14.27s	_14.34s	_{p=0.332 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,503k (± 0.01%)}	_{302,550k (± 0.01%)}	_~	_302,491k	_302,613k	_{p=0.065 n=6}
_{Parse Time}	_{2.01s (± 0.86%)}	_{1.99s (± 0.49%)}	_~	_1.98s	_2.01s	_{p=0.072 n=6}
_{Bind Time}	_{1.01s (± 0.97%)}	_{1.01s (± 1.20%)}	_~	_0.99s	_1.02s	_{p=0.865 n=6}
_{Check Time}	_{6.24s (± 0.19%)}	_{6.26s (± 0.55%)}	_~	_6.20s	_6.30s	_{p=0.256 n=6}
_{Emit Time}	_{3.52s (± 0.53%)}	_{3.52s (± 0.45%)}	_~	_3.50s	_3.55s	_{p=0.490 n=6}
_{Total Time}	_{12.77s (± 0.23%)}	_{12.78s (± 0.23%)}	_~	_12.73s	_12.81s	_{p=0.413 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,468k (± 0.00%)}	_{470,493k (± 0.01%)}	_~	_470,456k	_470,519k	_{p=0.173 n=6}
_{Parse Time}	_{2.56s (± 0.48%)}	_{2.57s (± 0.59%)}	_~	_2.55s	_2.59s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 1.18%)}	_{1.00s (± 0.84%)}	_~	_0.98s	_1.00s	_{p=0.555 n=6}
_{Check Time}	_{16.62s (± 0.43%)}	_{16.60s (± 0.33%)}	_~	_16.51s	_16.66s	_{p=0.627 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.35%)}	_{20.17s (± 0.32%)}	_~	_20.07s	_20.24s	_{p=0.747 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,559k (± 0.02%)}	_{512,535k (± 0.01%)}	_~	_512,435k	_512,635k	_{p=0.748 n=6}
_{Parse Time}	_{3.27s (± 0.45%)}	_{3.27s (± 0.32%)}	_~	_3.25s	_3.28s	_{p=1.000 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.55s (± 0.53%)}	_~	_1.54s	_1.56s	_{p=0.140 n=6}
_{Check Time}	_{2.83s (± 0.62%)}	_{2.84s (± 1.16%)}	_~	_2.80s	_2.89s	_{p=0.466 n=6}
_{Emit Time}	_{0.08s (± 5.21%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.71s (± 0.37%)}	_{7.73s (± 0.47%)}	_~	_7.68s	_7.78s	_{p=0.467 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-26T22:58:37Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/55851/merge:

Everything looks good!

ahejlsberg added 2 commits September 24, 2023 17:07

Relation overflow checks + fast path for intersections of unions

f66a633

Add tests

806ffbb

typescript-bot assigned ahejlsberg Sep 25, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 25, 2023

Merge branch 'main' into fix55630

89f5d10

# Conflicts: # src/compiler/diagnosticMessages.json

ahejlsberg requested review from sandersn, RyanCavanaugh and gabritto September 25, 2023 14:06

Add missing semicolon

ba6f527

gabritto approved these changes Sep 25, 2023

View reviewed changes

sandersn approved these changes Sep 26, 2023

View reviewed changes

ahejlsberg added 2 commits September 26, 2023 14:52

Add fast path for unions of unions

2d15222

Merge branch 'main' into fix55630

be68f32

# Conflicts: # src/compiler/diagnosticMessages.json

DanielRosenwasser merged commit c052bc7 into main Sep 26, 2023
19 checks passed

DanielRosenwasser deleted the fix55630 branch September 26, 2023 22:58

ahejlsberg mentioned this pull request Sep 28, 2023

Optimize comparing intersections with common members #50329

Open

Andarist mentioned this pull request Nov 30, 2023

Don't skip elaborations when reporting errors for cached failed relations #55234

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error on excessive relation complexity #55851

Error on excessive relation complexity #55851

ahejlsberg commented Sep 25, 2023 •

edited

ahejlsberg commented Sep 25, 2023

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023

Compiler

typescript-bot commented Sep 25, 2023

typescript-bot commented Sep 25, 2023

typescript-bot commented Sep 25, 2023

gabritto commented Sep 25, 2023

ahejlsberg commented Sep 25, 2023

ahejlsberg commented Sep 26, 2023

typescript-bot commented Sep 26, 2023 •

edited

typescript-bot commented Sep 26, 2023 •

edited

typescript-bot commented Sep 26, 2023 •

edited

typescript-bot commented Sep 26, 2023 •

edited

typescript-bot commented Sep 26, 2023

Compiler

typescript-bot commented Sep 26, 2023

Error on excessive relation complexity #55851

Error on excessive relation complexity #55851

Conversation

ahejlsberg commented Sep 25, 2023 • edited

ahejlsberg commented Sep 25, 2023

typescript-bot commented Sep 25, 2023 • edited

typescript-bot commented Sep 25, 2023 • edited

typescript-bot commented Sep 25, 2023 • edited

typescript-bot commented Sep 25, 2023 • edited

typescript-bot commented Sep 25, 2023

Compiler

typescript-bot commented Sep 25, 2023

typescript-bot commented Sep 25, 2023

typescript-bot commented Sep 25, 2023

gabritto commented Sep 25, 2023

ahejlsberg commented Sep 25, 2023

ahejlsberg commented Sep 26, 2023

typescript-bot commented Sep 26, 2023 • edited

typescript-bot commented Sep 26, 2023 • edited

typescript-bot commented Sep 26, 2023 • edited

typescript-bot commented Sep 26, 2023 • edited

typescript-bot commented Sep 26, 2023

Compiler

typescript-bot commented Sep 26, 2023

ahejlsberg commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 25, 2023 •

edited

typescript-bot commented Sep 26, 2023 •

edited

typescript-bot commented Sep 26, 2023 •

edited

typescript-bot commented Sep 26, 2023 •

edited

typescript-bot commented Sep 26, 2023 •

edited