-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up GHA workflows, use consistent bot token, etc #55923
Changes from all commits
984530c
8969c16
3f765b8
40e1b73
476cc03
81b8ba3
811ed7a
a3af9b6
7169599
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,9 +21,6 @@ jobs: | |
runs-on: ubuntu-latest | ||
if: github.repository == 'microsoft/TypeScript' | ||
|
||
permissions: | ||
contents: write | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
|
@@ -46,7 +43,7 @@ jobs: | |
echo "No change." | ||
else | ||
npm test | ||
npx hereby lkg | ||
npx hereby LKG | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the point of the LKG? Just as a test to see that it works? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. E.g. the LKG script silently broke because a dep updated, or something. Otherwise we wouldn't know until we attempted to do a release or nightly or something. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (this particular change is just to make all of the workflows have the same casing; silly, I know) |
||
git config user.email "typescriptbot@microsoft.com" | ||
git config user.name "TypeScript Bot" | ||
git add -f package-lock.json | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want this to be v4 also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly, this doesn't do a full fetch, so I don't need to bump it to get the new filter options.
I wanted to bump all of the versions but I'd need to update every file's version specifiers which felt noisy. Probably, we should enable dependabot but just for GHA. But either of those I'd rather in a different PR.