-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor default export info name gathering #58460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
PRs that fix a bug with a specific milestone
labels
May 7, 2024
@typescript-bot perf test |
@andrewbranch Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@andrewbranch Here are the results of running the top 200 repos comparing Something interesting changed - please have a look. DetailsServer exited prematurely with code unknown and signal SIGABRT
Affected reposcalcom/cal.comRaw error text:RepoResults7/calcom.cal.com.rawError.txt in the artifact folder
Last few requests{"seq":129,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/packages/prisma/seed.ts","line":493,"offset":29,"entryNames":["arguments"]}}
{"seq":130,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/prisma/seed.ts","line":510,"offset":49}}
{"seq":131,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/prisma/seed.ts","line":524,"offset":57,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":132,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/packages/prisma/seed.ts","line":524,"offset":57,"entryNames":["at"]}}
Repro steps
Server exited prematurely with code unknown and signal SIGABRT
Affected reposbabel/babelRaw error text:RepoResults3/babel.babel.rawError.txt in the artifact folder
Last few requests{"seq":272,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts","line":759,"offset":13}}
{"seq":273,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts","line":781,"offset":34}}
{"seq":274,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts","line":856,"offset":10}}
{"seq":275,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts","line":856,"offset":10}}
Repro steps
|
@andrewbranch Here are some more interesting changes from running the top 200 repos suite DetailsServer exited prematurely with code unknown and signal SIGABRT
Affected reposelastic/kibanaRaw error text:RepoResults14/elastic.kibana.rawError.txt in the artifact folder
Last few requests{"seq":418,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/x-pack/test/spaces_api_integration/common/services.ts","line":12,"offset":3,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":419,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/x-pack/test/spaces_api_integration/common/services.ts","line":12,"offset":3,"entryNames":["apiIntegrationServices"]}}
{"seq":420,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/packages/cloud/deployment_details/deployment_details.tsx"],"openFiles":[]}}
{"seq":421,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/x-pack/test/security_solution_cypress/cypress/cypress.config.ts","projectRootPath":"@PROJECT_ROOT@"}]}}
Repro steps
|
jakebailey
approved these changes
May 7, 2024
armanio123
approved these changes
May 7, 2024
sheetalkamat
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58044 (same as one crash in #57924)