This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
chore: Workaround for mockito #2860 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbjorge
reviewed
Jan 17, 2023
| ExclusionStrategy exclusionStrategy; | ||
| JsonSerializer<Class> jsonSerializer; | ||
| @Captor ArgumentCaptor<FieldNamingStrategy> fieldNamingStrategy; | ||
| @Captor ArgumentCaptor<ExclusionStrategy> exclusiontStrategy; |
There was a problem hiding this comment.
nit: typo
Suggested change
| @Captor ArgumentCaptor<ExclusionStrategy> exclusiontStrategy; | |
| @Captor ArgumentCaptor<ExclusionStrategy> exclusionStrategy; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Due to mockito/mockito#2860, Dependbot has been unable to update to any version of
mockito-inlinesince version 4.6.1. The failed attempts are as follows:In response to mockito/mockito#2860, a suggestion was made to use an
ArgumentCaptorto capture the arguments and theRETURNS_SELFparameter for the builder. This PR makes that change, so we're now capturing arguments using the construct that is intended for that purpose. The mockito team has not committed to fixing this issue and may even be leaning toward not fixing it, since a more officially supported option exists to do what we're doing.I've applied these changes locally to #198 and confirmed that the tests complete as expected.
Motivation
Allow newer versions of mockito
Context
Pull request checklist
./gradlew fastpassfromAccessibilityInsightsForAndroidServicefix:,chore:,feat(feature-name):,refactor:).