-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade Typescript version to 5.4.5 #7294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-prachin
changed the title
chore: Typescript Cleanup Part 3 of 3 for Visualization Type error Part 1
chore: Typescript Cleanup Part 3
Apr 4, 2024
v-rakeshsh
reviewed
Apr 9, 2024
src/tests/unit/tests/common/configs/web-visualization-configuration-factory.test.ts
Outdated
Show resolved
Hide resolved
chore: Typescript Cleanup Part 3 of 3 for Visualization Type error
v-viyada
changed the title
chore: Typescript Cleanup Part 3
chore: Upgrade Typescript version to 5.4.5
May 7, 2024
madalynrose
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing work, team!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Typescript Cleanup Part 3 of 3
Covering 80 errors in 40 files in this PR
Motivation
SUBPART 1:
Number of errors covered as part of this user story: 25
SUBPART 2:
Merged PR2 which had these files fixed:
v-prachin#1
Number of errors covered as part of this user story: 25
SUBPART 3:
Number of errors covered as part of this user story: 30
Total Number of errors covered as part of this user story: 80
src/common/components/cards/instance-details-group.tsx
src/DetailsView/details-view-initializer.ts
Due to typescript changes the style of the snapshot file got re-arranged. So updated the snapshot files.
Context
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.