BREAKING CHANGE: Use Node 20 instead of Node 16 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeofdusk
approved these changes
Oct 23, 2023
| @@ -12,7 +12,7 @@ | |||
| "README.md" | |||
| ], | |||
| "engines": { | |||
| "node": ">= 8" | |||
There was a problem hiding this comment.
8 to 20 feels like a big jump. Is the intent to use features that require Node >= 20 in future commits?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Node 16 left support in October 2023. The only known consumer of axe-sarif-converter is the accessibility-insights-service repo, which already uses Node 20.
Motivation
Get on a supported version that we expect to last for a while
Context
Pull request checklist
fix:,feat:, etc, and is suitable for user-facing release notes)BREAKING CHANGE:yarn precheckinBREAKING CHANGES