Remove SAS-tokens in ArcBox #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
likamrat
approved these changes
May 27, 2024
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on changes to the
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1file. The changes simplify the way the script handles thevhdSourceFolderURL and theazcopy cpcommand. The URL for thevhdSourceFolderis now a direct link, and theazcopy cpcommand no longer uses a separatesasvariable.Changes in
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1:$vhdSourceFolderURL simplified: The$vhdSourceFolderURL has been changed to a direct link, removing the need for thesasvariable.azcopy cpcommand simplified: Theazcopy cpcommand has been updated in two places. It no longer uses thesasvariable, instead directly using the$vhdSourceFolderURL. This change was made in theif ($Env:flavor -ne "DevOps") {blocks, affecting both the SQL VM and other VMs. [1] [2]